Merge pull request #30985 from wojtek-t/improve_etcd_watchers

Automatic merge from submit-queue

Increase buffer size in etcd_watcher

Should help with #30873

@xiang90 @hongchaodeng @kubernetes/sig-scalability
This commit is contained in:
Kubernetes Submit Queue 2016-08-19 04:58:24 -07:00 committed by GitHub
commit 2707c46a32

View File

@ -139,13 +139,15 @@ func newEtcdWatcher(
// monitor how much of this buffer is actually used. // monitor how much of this buffer is actually used.
etcdIncoming: make(chan *etcd.Response, 100), etcdIncoming: make(chan *etcd.Response, 100),
etcdError: make(chan error, 1), etcdError: make(chan error, 1),
outgoing: make(chan watch.Event), // Similarly to etcdIncomming, we don't want to force context
userStop: make(chan struct{}), // switch on every new incoming object.
stopped: false, outgoing: make(chan watch.Event, 100),
wg: sync.WaitGroup{}, userStop: make(chan struct{}),
cache: cache, stopped: false,
ctx: nil, wg: sync.WaitGroup{},
cancel: nil, cache: cache,
ctx: nil,
cancel: nil,
} }
w.emit = func(e watch.Event) { w.emit = func(e watch.Event) {
// Give up on user stop, without this we leak a lot of goroutines in tests. // Give up on user stop, without this we leak a lot of goroutines in tests.