diff --git a/pkg/kubelet/network/kubenet/BUILD b/pkg/kubelet/network/kubenet/BUILD index 3db64aeac25..724d1d65ef6 100644 --- a/pkg/kubelet/network/kubenet/BUILD +++ b/pkg/kubelet/network/kubenet/BUILD @@ -31,7 +31,6 @@ go_library( "//vendor:github.com/containernetworking/cni/pkg/types", "//vendor:github.com/golang/glog", "//vendor:github.com/vishvananda/netlink", - "//vendor:github.com/vishvananda/netlink/nl", ], ) diff --git a/pkg/kubelet/network/kubenet/kubenet_linux.go b/pkg/kubelet/network/kubenet/kubenet_linux.go index be5495ee371..63be4e168dd 100644 --- a/pkg/kubelet/network/kubenet/kubenet_linux.go +++ b/pkg/kubelet/network/kubenet/kubenet_linux.go @@ -33,7 +33,6 @@ import ( cnitypes "github.com/containernetworking/cni/pkg/types" "github.com/golang/glog" "github.com/vishvananda/netlink" - "github.com/vishvananda/netlink/nl" "k8s.io/kubernetes/pkg/api/v1" "k8s.io/kubernetes/pkg/apis/componentconfig" kubecontainer "k8s.io/kubernetes/pkg/kubelet/container" @@ -296,37 +295,6 @@ func (plugin *kubenetNetworkPlugin) clearBridgeAddressesExcept(keep *net.IPNet) } } -// ensureBridgeTxQueueLen() ensures that the bridge interface's TX queue -// length is greater than zero. Due to a CNI <= 0.3.0 'bridge' plugin bug, -// the bridge is initially created with a TX queue length of 0, which gets -// used as the packet limit for FIFO traffic shapers, which drops packets. -// TODO: remove when we can depend on a fixed CNI -func (plugin *kubenetNetworkPlugin) ensureBridgeTxQueueLen() { - bridge, err := netlink.LinkByName(BridgeName) - if err != nil { - return - } - - if bridge.Attrs().TxQLen > 0 { - return - } - - req := nl.NewNetlinkRequest(syscall.RTM_NEWLINK, syscall.NLM_F_ACK) - msg := nl.NewIfInfomsg(syscall.AF_UNSPEC) - req.AddData(msg) - - nameData := nl.NewRtAttr(syscall.IFLA_IFNAME, nl.ZeroTerminated(BridgeName)) - req.AddData(nameData) - - qlen := nl.NewRtAttr(syscall.IFLA_TXQLEN, nl.Uint32Attr(1000)) - req.AddData(qlen) - - _, err = req.Execute(syscall.NETLINK_ROUTE, 0) - if err != nil { - glog.V(5).Infof("Failed to set bridge tx queue length: %v", err) - } -} - func (plugin *kubenetNetworkPlugin) Name() string { return KubenetPluginName } @@ -789,7 +757,6 @@ func (plugin *kubenetNetworkPlugin) delContainerFromNetwork(config *libcni.Netwo func (plugin *kubenetNetworkPlugin) shaper() bandwidth.BandwidthShaper { if plugin.bandwidthShaper == nil { plugin.bandwidthShaper = bandwidth.NewTCShaper(BridgeName) - plugin.ensureBridgeTxQueueLen() plugin.bandwidthShaper.ReconcileInterface() } return plugin.bandwidthShaper