diff --git a/pkg/api/errors/etcd/doc.go b/pkg/api/errors/storage/doc.go similarity index 97% rename from pkg/api/errors/etcd/doc.go rename to pkg/api/errors/storage/doc.go index 8cc0a832edd..a2a550526c9 100644 --- a/pkg/api/errors/etcd/doc.go +++ b/pkg/api/errors/storage/doc.go @@ -15,4 +15,4 @@ limitations under the License. */ // Package etcd provides conversion of etcd errors to API errors. -package etcd +package storage diff --git a/pkg/api/errors/etcd/etcd.go b/pkg/api/errors/storage/storage.go similarity index 99% rename from pkg/api/errors/etcd/etcd.go rename to pkg/api/errors/storage/storage.go index 04d03bd646a..ebb23e91c39 100644 --- a/pkg/api/errors/etcd/etcd.go +++ b/pkg/api/errors/storage/storage.go @@ -14,7 +14,7 @@ See the License for the specific language governing permissions and limitations under the License. */ -package etcd +package storage import ( "k8s.io/kubernetes/pkg/api/errors" diff --git a/pkg/registry/deployment/etcd/etcd.go b/pkg/registry/deployment/etcd/etcd.go index c72bf5c6612..27a5236e3e2 100644 --- a/pkg/registry/deployment/etcd/etcd.go +++ b/pkg/registry/deployment/etcd/etcd.go @@ -21,7 +21,7 @@ import ( "k8s.io/kubernetes/pkg/api" "k8s.io/kubernetes/pkg/api/errors" - etcderr "k8s.io/kubernetes/pkg/api/errors/etcd" + storeerr "k8s.io/kubernetes/pkg/api/errors/storage" "k8s.io/kubernetes/pkg/api/rest" "k8s.io/kubernetes/pkg/apis/extensions" extvalidation "k8s.io/kubernetes/pkg/apis/extensions/validation" @@ -148,8 +148,8 @@ func (r *RollbackREST) Create(ctx api.Context, obj runtime.Object) (out runtime. func (r *RollbackREST) rollbackDeployment(ctx api.Context, deploymentID string, config *extensions.RollbackConfig, annotations map[string]string) (err error) { if _, err = r.setDeploymentRollback(ctx, deploymentID, config, annotations); err != nil { - err = etcderr.InterpretGetError(err, extensions.Resource("deployments"), deploymentID) - err = etcderr.InterpretUpdateError(err, extensions.Resource("deployments"), deploymentID) + err = storeerr.InterpretGetError(err, extensions.Resource("deployments"), deploymentID) + err = storeerr.InterpretUpdateError(err, extensions.Resource("deployments"), deploymentID) if _, ok := err.(*errors.StatusError); !ok { err = errors.NewConflict(extensions.Resource("deployments/rollback"), deploymentID, err) } diff --git a/pkg/registry/deployment/etcd/etcd_test.go b/pkg/registry/deployment/etcd/etcd_test.go index f4fd1b7ace5..be57ea8281a 100644 --- a/pkg/registry/deployment/etcd/etcd_test.go +++ b/pkg/registry/deployment/etcd/etcd_test.go @@ -22,7 +22,7 @@ import ( "k8s.io/kubernetes/pkg/api" "k8s.io/kubernetes/pkg/api/errors" - etcderrors "k8s.io/kubernetes/pkg/api/errors/etcd" + storeerr "k8s.io/kubernetes/pkg/api/errors/storage" "k8s.io/kubernetes/pkg/api/unversioned" "k8s.io/kubernetes/pkg/apis/extensions" "k8s.io/kubernetes/pkg/fields" @@ -366,7 +366,7 @@ func TestEtcdCreateDeploymentRollbackNoDeployment(t *testing.T) { if err == nil { t.Fatalf("Expected not-found-error but got nothing") } - if !errors.IsNotFound(etcderrors.InterpretGetError(err, extensions.Resource("deployments"), name)) { + if !errors.IsNotFound(storeerr.InterpretGetError(err, extensions.Resource("deployments"), name)) { t.Fatalf("Unexpected error returned: %#v", err) } @@ -374,7 +374,7 @@ func TestEtcdCreateDeploymentRollbackNoDeployment(t *testing.T) { if err == nil { t.Fatalf("Expected not-found-error but got nothing") } - if !errors.IsNotFound(etcderrors.InterpretGetError(err, extensions.Resource("deployments"), name)) { + if !errors.IsNotFound(storeerr.InterpretGetError(err, extensions.Resource("deployments"), name)) { t.Fatalf("Unexpected error: %v", err) } } diff --git a/pkg/registry/generic/etcd/etcd.go b/pkg/registry/generic/etcd/etcd.go index 439df6dbfc2..857b24972b2 100644 --- a/pkg/registry/generic/etcd/etcd.go +++ b/pkg/registry/generic/etcd/etcd.go @@ -23,7 +23,7 @@ import ( "k8s.io/kubernetes/pkg/api" kubeerr "k8s.io/kubernetes/pkg/api/errors" - etcderr "k8s.io/kubernetes/pkg/api/errors/etcd" + storeerr "k8s.io/kubernetes/pkg/api/errors/storage" "k8s.io/kubernetes/pkg/api/meta" "k8s.io/kubernetes/pkg/api/rest" "k8s.io/kubernetes/pkg/api/unversioned" @@ -188,7 +188,7 @@ func (e *Etcd) ListPredicate(ctx api.Context, m generic.Matcher, options *api.Li if name, ok := m.MatchesSingle(); ok { if key, err := e.KeyFunc(ctx, name); err == nil { err := e.Storage.GetToList(ctx, key, filterFunc, list) - return list, etcderr.InterpretListError(err, e.QualifiedResource) + return list, storeerr.InterpretListError(err, e.QualifiedResource) } // if we cannot extract a key based on the current context, the optimization is skipped } @@ -197,7 +197,7 @@ func (e *Etcd) ListPredicate(ctx api.Context, m generic.Matcher, options *api.Li options = &api.ListOptions{ResourceVersion: "0"} } err := e.Storage.List(ctx, e.KeyRootFunc(ctx), options.ResourceVersion, filterFunc, list) - return list, etcderr.InterpretListError(err, e.QualifiedResource) + return list, storeerr.InterpretListError(err, e.QualifiedResource) } // Create inserts a new item according to the unique key from the object. @@ -219,7 +219,7 @@ func (e *Etcd) Create(ctx api.Context, obj runtime.Object) (runtime.Object, erro } out := e.NewFunc() if err := e.Storage.Create(ctx, key, obj, out, ttl); err != nil { - err = etcderr.InterpretCreateError(err, e.QualifiedResource, name) + err = storeerr.InterpretCreateError(err, e.QualifiedResource, name) err = rest.CheckGeneratedNameError(e.CreateStrategy, err, obj) return nil, err } @@ -328,10 +328,10 @@ func (e *Etcd) Update(ctx api.Context, obj runtime.Object) (runtime.Object, bool if err != nil { if creating { - err = etcderr.InterpretCreateError(err, e.QualifiedResource, name) + err = storeerr.InterpretCreateError(err, e.QualifiedResource, name) err = rest.CheckGeneratedNameError(e.CreateStrategy, err, obj) } else { - err = etcderr.InterpretUpdateError(err, e.QualifiedResource, name) + err = storeerr.InterpretUpdateError(err, e.QualifiedResource, name) } return nil, false, err } @@ -364,7 +364,7 @@ func (e *Etcd) Get(ctx api.Context, name string) (runtime.Object, error) { return nil, err } if err := e.Storage.Get(ctx, key, obj, false); err != nil { - return nil, etcderr.InterpretGetError(err, e.QualifiedResource, name) + return nil, storeerr.InterpretGetError(err, e.QualifiedResource, name) } if e.Decorator != nil { if err := e.Decorator(obj); err != nil { @@ -388,7 +388,7 @@ func (e *Etcd) Delete(ctx api.Context, name string, options *api.DeleteOptions) obj := e.NewFunc() if err := e.Storage.Get(ctx, key, obj, false); err != nil { - return nil, etcderr.InterpretDeleteError(err, e.QualifiedResource, name) + return nil, storeerr.InterpretDeleteError(err, e.QualifiedResource, name) } // support older consumers of delete by treating "nil" as delete immediately @@ -445,7 +445,7 @@ func (e *Etcd) Delete(ctx api.Context, name string, options *api.DeleteOptions) case errAlreadyDeleting: return e.finalizeDelete(obj, true) default: - return nil, etcderr.InterpretUpdateError(err, e.QualifiedResource, name) + return nil, storeerr.InterpretUpdateError(err, e.QualifiedResource, name) } } @@ -459,7 +459,7 @@ func (e *Etcd) Delete(ctx api.Context, name string, options *api.DeleteOptions) // before its deletion, but it's the best approximation. return e.finalizeDelete(lastExisting, true) } - return nil, etcderr.InterpretDeleteError(err, e.QualifiedResource, name) + return nil, storeerr.InterpretDeleteError(err, e.QualifiedResource, name) } return e.finalizeDelete(out, true) } diff --git a/pkg/registry/pod/etcd/etcd.go b/pkg/registry/pod/etcd/etcd.go index b401bfea98e..c404fc48afd 100644 --- a/pkg/registry/pod/etcd/etcd.go +++ b/pkg/registry/pod/etcd/etcd.go @@ -23,7 +23,7 @@ import ( "k8s.io/kubernetes/pkg/api" "k8s.io/kubernetes/pkg/api/errors" - etcderr "k8s.io/kubernetes/pkg/api/errors/etcd" + storeerr "k8s.io/kubernetes/pkg/api/errors/storage" "k8s.io/kubernetes/pkg/api/rest" "k8s.io/kubernetes/pkg/api/unversioned" "k8s.io/kubernetes/pkg/api/validation" @@ -175,8 +175,8 @@ func (r *BindingREST) setPodHostAndAnnotations(ctx api.Context, podID, oldMachin // assignPod assigns the given pod to the given machine. func (r *BindingREST) assignPod(ctx api.Context, podID string, machine string, annotations map[string]string) (err error) { if _, err = r.setPodHostAndAnnotations(ctx, podID, "", machine, annotations); err != nil { - err = etcderr.InterpretGetError(err, api.Resource("pods"), podID) - err = etcderr.InterpretUpdateError(err, api.Resource("pods"), podID) + err = storeerr.InterpretGetError(err, api.Resource("pods"), podID) + err = storeerr.InterpretUpdateError(err, api.Resource("pods"), podID) if _, ok := err.(*errors.StatusError); !ok { err = errors.NewConflict(api.Resource("pods/binding"), podID, err) } diff --git a/pkg/registry/pod/etcd/etcd_test.go b/pkg/registry/pod/etcd/etcd_test.go index e88818f211b..df2307c25e9 100644 --- a/pkg/registry/pod/etcd/etcd_test.go +++ b/pkg/registry/pod/etcd/etcd_test.go @@ -24,7 +24,7 @@ import ( "golang.org/x/net/context" "k8s.io/kubernetes/pkg/api" "k8s.io/kubernetes/pkg/api/errors" - etcderrors "k8s.io/kubernetes/pkg/api/errors/etcd" + storeerr "k8s.io/kubernetes/pkg/api/errors/storage" "k8s.io/kubernetes/pkg/api/rest" "k8s.io/kubernetes/pkg/fields" "k8s.io/kubernetes/pkg/labels" @@ -422,7 +422,7 @@ func TestEtcdCreateBindingNoPod(t *testing.T) { if err == nil { t.Fatalf("Expected not-found-error but got nothing") } - if !errors.IsNotFound(etcderrors.InterpretGetError(err, api.Resource("pods"), "foo")) { + if !errors.IsNotFound(storeerr.InterpretGetError(err, api.Resource("pods"), "foo")) { t.Fatalf("Unexpected error returned: %#v", err) } @@ -430,7 +430,7 @@ func TestEtcdCreateBindingNoPod(t *testing.T) { if err == nil { t.Fatalf("Expected not-found-error but got nothing") } - if !errors.IsNotFound(etcderrors.InterpretGetError(err, api.Resource("pods"), "foo")) { + if !errors.IsNotFound(storeerr.InterpretGetError(err, api.Resource("pods"), "foo")) { t.Fatalf("Unexpected error: %v", err) } } diff --git a/pkg/registry/service/allocator/etcd/etcd.go b/pkg/registry/service/allocator/etcd/etcd.go index 366b814b4fc..b261c69b556 100644 --- a/pkg/registry/service/allocator/etcd/etcd.go +++ b/pkg/registry/service/allocator/etcd/etcd.go @@ -23,7 +23,7 @@ import ( "k8s.io/kubernetes/pkg/api" k8serr "k8s.io/kubernetes/pkg/api/errors" - etcderr "k8s.io/kubernetes/pkg/api/errors/etcd" + storeerr "k8s.io/kubernetes/pkg/api/errors/storage" "k8s.io/kubernetes/pkg/api/unversioned" "k8s.io/kubernetes/pkg/registry/service" "k8s.io/kubernetes/pkg/registry/service/allocator" @@ -164,7 +164,7 @@ func (e *Etcd) tryUpdate(fn func() error) error { return existing, nil }), ) - return etcderr.InterpretUpdateError(err, e.resource, "") + return storeerr.InterpretUpdateError(err, e.resource, "") } // Refresh reloads the RangeAllocation from etcd. @@ -177,7 +177,7 @@ func (e *Etcd) Refresh() (*api.RangeAllocation, error) { if storage.IsNotFound(err) { return nil, nil } - return nil, etcderr.InterpretGetError(err, e.resource, "") + return nil, storeerr.InterpretGetError(err, e.resource, "") } return existing, nil @@ -188,7 +188,7 @@ func (e *Etcd) Refresh() (*api.RangeAllocation, error) { func (e *Etcd) Get() (*api.RangeAllocation, error) { existing := &api.RangeAllocation{} if err := e.storage.Get(context.TODO(), e.baseKey, existing, true); err != nil { - return nil, etcderr.InterpretGetError(err, e.resource, "") + return nil, storeerr.InterpretGetError(err, e.resource, "") } return existing, nil } @@ -216,7 +216,7 @@ func (e *Etcd) CreateOrUpdate(snapshot *api.RangeAllocation) error { }), ) if err != nil { - return etcderr.InterpretUpdateError(err, e.resource, "") + return storeerr.InterpretUpdateError(err, e.resource, "") } err = e.alloc.Restore(snapshot.Range, snapshot.Data) if err == nil {