github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-05 10:19:50 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #25240 from thockin/fix-codecgen-sort

Browse Source 
Fix codecgen sort
This commit is contained in:
Wojciech Tyczynski 2016-05-06 08:28:51 +02:00
commit 28a8a23471
1 changed files with 27 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

45
hack/update-codecgen.sh
View File

@ -39,6 +39,9 @@ generated_files=($(
\) -prune \ \) -prune \
\) -name '*.generated.go' | sort -r)) \) -name '*.generated.go' | sort -r))
# We only work for deps within this prefix.
my_prefix="k8s.io/kubernetes"
# Register function to be called on EXIT to remove codecgen # Register function to be called on EXIT to remove codecgen
# binary and also to touch the files that should be regenerated # binary and also to touch the files that should be regenerated
# since they are first removed. # since they are first removed.
@ -55,28 +58,31 @@ trap cleanup EXIT
# Sort all files in the dependency order. # Sort all files in the dependency order.
number=${#generated_files[@]} number=${#generated_files[@]}
result=""
for (( i=0; i<number; i++ )); do for (( i=0; i<number; i++ )); do
visited[${i}]=false visited[${i}]=false
done done
result="" ###echo "DBG: found $number generated files"
###for f in $(echo "${generated_files[@]}" | sort); do
### echo "DBG: $f"
###done
# NOTE: depends function assumes that the whole repository is under # NOTE: depends function assumes that the whole repository is under
# */k8s.io/kubernetes directory - it will NOT work if that is not true. # $my_prefix - it will NOT work if that is not true.
function depends { function depends {
file=${generated_files[$1]//\.generated\.go/.go} file="${generated_files[$1]/\.generated\.go/.go}"
deps=$(go list -f "{{.Deps}}" ${file} | tr "[" " " | tr "]" " ") rhs="$(dirname ${generated_files[$2]/#./${my_prefix}})"
candidate=$(readlinkdashf "${generated_files[$2]//\.generated\.go/.go}") ###echo "DBG: does ${file} depend on ${rhs}?"
deps=$(go list -f '{{range .Deps}}{{.}}{{"\n"}}{{end}}' ${file} | grep "^${my_prefix}")
for dep in ${deps}; do for dep in ${deps}; do
# Only look at dependencies within the kubernetes tree-- otherwise the "io" ###echo "DBG: checking against $dep"
# package matches the end of one of our directories. if [[ "${dep}" == "${rhs}" ]]; then
if [[ ${dep} = "k8s.io"* ]]; then ###echo "DBG: = yes"
if [[ ${candidate} = *${dep} ]]; then return 0
echo true
return
fi
fi fi
done done
echo false ###echo "DBG: = no"
return 1
} }
function tsort { function tsort {
@ -84,15 +90,18 @@ function tsort {
local j=0 local j=0
for (( j=0; j<number; j++ )); do for (( j=0; j<number; j++ )); do
if ! ${visited[${j}]}; then if ! ${visited[${j}]}; then
if $(depends "$1" ${j}); then if depends "$1" ${j}; then
tsort $j tsort $j
fi fi
fi fi
done done
result="${result} $1" result="${result} $1"
} }
echo "Building dependencies"
for (( i=0; i<number; i++ )); do for (( i=0; i<number; i++ )); do
###echo "DBG: considering ${generated_files[${i}]}"
if ! ${visited[${i}]}; then if ! ${visited[${i}]}; then
###echo "DBG: tsorting ${generated_files[${i}]}"
tsort ${i} tsort ${i}
fi fi
done done
@ -106,6 +115,7 @@ if [[ -z ${haveindex} ]]; then
exit 1 exit 1
fi fi
echo "Building codecgen"
CODECGEN="${PWD}/codecgen_binary" CODECGEN="${PWD}/codecgen_binary"
godep go build -o "${CODECGEN}" github.com/ugorji/go/codec/codecgen godep go build -o "${CODECGEN}" github.com/ugorji/go/codec/codecgen
@ -121,8 +131,8 @@ done
for current in "${index[@]}"; do for current in "${index[@]}"; do
generated_file=${generated_files[${current}]} generated_file=${generated_files[${current}]}
initial_dir=${PWD} initial_dir=${PWD}
file=${generated_file//\.generated\.go/.go} file=${generated_file/\.generated\.go/.go}
echo "codecgen processing ${file}" echo "processing ${file}"
# codecgen work only if invoked from directory where the file # codecgen work only if invoked from directory where the file
# is located. # is located.
pushd "$(dirname ${file})" > /dev/null pushd "$(dirname ${file})" > /dev/null
@ -130,12 +140,11 @@ for current in "${index[@]}"; do
base_generated_file=$(basename "${generated_file}") base_generated_file=$(basename "${generated_file}")
# We use '-d 1234' flag to have a deterministic output every time. # We use '-d 1234' flag to have a deterministic output every time.
# The constant was just randomly chosen. # The constant was just randomly chosen.
echo Running ${CODECGEN} -d 1234 -o "${base_generated_file}" "${base_file}" ###echo "DBG: running ${CODECGEN} -d 1234 -o ${base_generated_file} ${base_file}"
${CODECGEN} -d 1234 -o "${base_generated_file}" "${base_file}" ${CODECGEN} -d 1234 -o "${base_generated_file}" "${base_file}"
# Add boilerplate at the beginning of the generated file. # Add boilerplate at the beginning of the generated file.
sed 's/YEAR/2015/' "${initial_dir}/hack/boilerplate/boilerplate.go.txt" > "${base_generated_file}.tmp" sed 's/YEAR/2015/' "${initial_dir}/hack/boilerplate/boilerplate.go.txt" > "${base_generated_file}.tmp"
cat "${base_generated_file}" >> "${base_generated_file}.tmp" cat "${base_generated_file}" >> "${base_generated_file}.tmp"
mv "${base_generated_file}.tmp" "${base_generated_file}" mv "${base_generated_file}.tmp" "${base_generated_file}"
echo "${generated_file} is regenerated."
popd > /dev/null popd > /dev/null
done done