From 28e973c04472bc31097d1483db97e3344e9cc764 Mon Sep 17 00:00:00 2001 From: Tim Hockin Date: Mon, 14 Apr 2025 09:51:47 -0700 Subject: [PATCH] Better formatting of matcher errors --- .../apimachinery/pkg/util/validation/field/error_matcher.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/staging/src/k8s.io/apimachinery/pkg/util/validation/field/error_matcher.go b/staging/src/k8s.io/apimachinery/pkg/util/validation/field/error_matcher.go index 1d15deae868..d1f24e404b7 100644 --- a/staging/src/k8s.io/apimachinery/pkg/util/validation/field/error_matcher.go +++ b/staging/src/k8s.io/apimachinery/pkg/util/validation/field/error_matcher.go @@ -88,7 +88,11 @@ func (m ErrorMatcher) Render(e *Error) string { } if m.matchValue { comma() - buf.WriteString(fmt.Sprintf("Value=%v", e.BadValue)) + if s, ok := e.BadValue.(string); ok { + buf.WriteString(fmt.Sprintf("Value=%q", s)) + } else { + buf.WriteString(fmt.Sprintf("Value=%v", e.BadValue)) + } } if m.matchOrigin || m.requireOriginWhenInvalid && e.Type == ErrorTypeInvalid { comma()