github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-25 04:33:26 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #95230 from Git-Jiro/fix_vendor_client_go

Browse Source 
Fix staticchecks in vendor/k8s.io/client-go
This commit is contained in:
Kubernetes Prow Robot 2020-10-15 06:04:37 -07:00 committed by GitHub
commit 297b021f49
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 10 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
hack/.staticcheck_failures
View File

@ -49,12 +49,8 @@ vendor/k8s.io/apiserver/plugin/pkg/authenticator/token/webhook
vendor/k8s.io/apiserver/plugin/pkg/authorizer/webhook vendor/k8s.io/apiserver/plugin/pkg/authorizer/webhook
vendor/k8s.io/cli-runtime/pkg/printers vendor/k8s.io/cli-runtime/pkg/printers
vendor/k8s.io/client-go/discovery vendor/k8s.io/client-go/discovery
vendor/k8s.io/client-go/dynamic/fake
vendor/k8s.io/client-go/metadata/fake
vendor/k8s.io/client-go/rest vendor/k8s.io/client-go/rest
vendor/k8s.io/client-go/rest/watch vendor/k8s.io/client-go/rest/watch
vendor/k8s.io/client-go/restmapper
vendor/k8s.io/client-go/tools/leaderelection
vendor/k8s.io/client-go/transport vendor/k8s.io/client-go/transport
vendor/k8s.io/kubectl/pkg/cmd/scale vendor/k8s.io/kubectl/pkg/cmd/scale
vendor/k8s.io/metrics/pkg/client/custom_metrics vendor/k8s.io/metrics/pkg/client/custom_metrics

6
staging/src/k8s.io/client-go/dynamic/fake/simple.go
View File

@ -96,7 +96,8 @@ func (c *dynamicResourceClient) Create(ctx context.Context, obj *unstructured.Un
Invokes(testing.NewRootCreateAction(c.resource, obj), obj) Invokes(testing.NewRootCreateAction(c.resource, obj), obj)
case len(c.namespace) == 0 && len(subresources) > 0: case len(c.namespace) == 0 && len(subresources) > 0:
accessor, err := meta.Accessor(obj) var accessor metav1.Object // avoid shadowing err
accessor, err = meta.Accessor(obj)
if err != nil { if err != nil {
return nil, err return nil, err
} }
@ -109,7 +110,8 @@ func (c *dynamicResourceClient) Create(ctx context.Context, obj *unstructured.Un
Invokes(testing.NewCreateAction(c.resource, c.namespace, obj), obj) Invokes(testing.NewCreateAction(c.resource, c.namespace, obj), obj)
case len(c.namespace) > 0 && len(subresources) > 0: case len(c.namespace) > 0 && len(subresources) > 0:
accessor, err := meta.Accessor(obj) var accessor metav1.Object // avoid shadowing err
accessor, err = meta.Accessor(obj)
if err != nil { if err != nil {
return nil, err return nil, err
} }

6
staging/src/k8s.io/client-go/metadata/fake/simple.go
View File

@ -114,7 +114,8 @@ func (c *metadataResourceClient) CreateFake(obj *metav1.PartialObjectMetadata, o
Invokes(testing.NewRootCreateAction(c.resource, obj), obj) Invokes(testing.NewRootCreateAction(c.resource, obj), obj)
case len(c.namespace) == 0 && len(subresources) > 0: case len(c.namespace) == 0 && len(subresources) > 0:
accessor, err := meta.Accessor(obj) var accessor metav1.Object // avoid shadowing err
accessor, err = meta.Accessor(obj)
if err != nil { if err != nil {
return nil, err return nil, err
} }
@ -127,7 +128,8 @@ func (c *metadataResourceClient) CreateFake(obj *metav1.PartialObjectMetadata, o
Invokes(testing.NewCreateAction(c.resource, c.namespace, obj), obj) Invokes(testing.NewCreateAction(c.resource, c.namespace, obj), obj)
case len(c.namespace) > 0 && len(subresources) > 0: case len(c.namespace) > 0 && len(subresources) > 0:
accessor, err := meta.Accessor(obj) var accessor metav1.Object // avoid shadowing err
accessor, err = meta.Accessor(obj)
if err != nil { if err != nil {
return nil, err return nil, err
} }

2
staging/src/k8s.io/client-go/restmapper/category_expansion.go
View File

@ -58,7 +58,7 @@ func NewDiscoveryCategoryExpander(client discovery.DiscoveryInterface) CategoryE
// Expand fulfills CategoryExpander // Expand fulfills CategoryExpander
func (e discoveryCategoryExpander) Expand(category string) ([]schema.GroupResource, bool) { func (e discoveryCategoryExpander) Expand(category string) ([]schema.GroupResource, bool) {
// Get all supported resources for groups and versions from server, if no resource found, fallback anyway. // Get all supported resources for groups and versions from server, if no resource found, fallback anyway.
apiResourceLists, _ := e.discoveryClient.ServerResources() _, apiResourceLists, _ := e.discoveryClient.ServerGroupsAndResources()
if len(apiResourceLists) == 0 { if len(apiResourceLists) == 0 {
return nil, false return nil, false
} }

2
staging/src/k8s.io/client-go/restmapper/shortcut.go
View File

@ -84,7 +84,7 @@ func (e shortcutExpander) getShortcutMappings() ([]*metav1.APIResourceList, []re
res := []resourceShortcuts{} res := []resourceShortcuts{}
// get server resources // get server resources
// This can return an error *and* the results it was able to find. We don't need to fail on the error. // This can return an error *and* the results it was able to find. We don't need to fail on the error.
apiResList, err := e.discoveryClient.ServerResources() _, apiResList, err := e.discoveryClient.ServerGroupsAndResources()
if err != nil { if err != nil {
klog.V(1).Infof("Error loading discovery information: %v", err) klog.V(1).Infof("Error loading discovery information: %v", err)
} }

3
staging/src/k8s.io/client-go/tools/leaderelection/leaderelection.go
View File

@ -188,9 +188,6 @@ type LeaderElector struct {
clock clock.Clock clock clock.Clock
metrics leaderMetricsAdapter metrics leaderMetricsAdapter
// name is the name of the resource lock for debugging
name string
} }
// Run starts the leader election loop. Run will not return // Run starts the leader election loop. Run will not return