From 29d6d03a3cf7433f5ad1ca81ba8dc986a6dc023c Mon Sep 17 00:00:00 2001 From: Patrick Ohly Date: Mon, 19 Dec 2022 07:58:10 +0100 Subject: [PATCH] e2e scheduling: fix scope of context.WithTimeout The original intend from v1.26.0 was to only apply the timeout to the following cache.WaitForCacheSync. --- test/e2e/scheduling/limit_range.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/e2e/scheduling/limit_range.go b/test/e2e/scheduling/limit_range.go index 8cdf6f158a2..0bb77388cca 100644 --- a/test/e2e/scheduling/limit_range.go +++ b/test/e2e/scheduling/limit_range.go @@ -93,9 +93,9 @@ var _ = SIGDescribe("LimitRange", func() { _, informer, w, _ := watchtools.NewIndexerInformerWatcher(lw, &v1.LimitRange{}) defer w.Stop() - ctx, cancelCtx := context.WithTimeout(ctx, wait.ForeverTestTimeout) - defer cancelCtx() - if !cache.WaitForCacheSync(ctx.Done(), informer.HasSynced) { + timeoutCtx, cancel := context.WithTimeout(ctx, wait.ForeverTestTimeout) + defer cancel() + if !cache.WaitForCacheSync(timeoutCtx.Done(), informer.HasSynced) { framework.Failf("Timeout while waiting for LimitRange informer to sync") }