github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-17 15:50:10 +00:00
Code Issues Projects Releases Wiki Activity

Improvement suggested by PR comment

Browse Source 
Fail early makes the code more readable
This commit is contained in:
ampsingram 2019-01-16 18:18:16 -05:00
parent 207a5a1267
commit 2a6ed9a698
1 changed files with 25 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
pkg/cloudprovider/providers/aws/aws.go
View File

@ -609,7 +609,10 @@ func makeRegionEndpointSignature(serviceName, region string) string {
} }
func parseOverrides(cfg *CloudConfig) error { func parseOverrides(cfg *CloudConfig) error {
if len(cfg.Global.ServiceOverrides) > 0 { overridesActive = false
if len(cfg.Global.ServiceOverrides) == 0 {
return nil
}
if err := setOverridesDefaults(cfg); err != nil { if err := setOverridesDefaults(cfg); err != nil {
return err return err
} }
@ -632,9 +635,6 @@ func parseOverrides(cfg *CloudConfig) error {
overrides[signature] = CustomEndpoint{Endpoint: url, SigningRegion: signingRegion} overrides[signature] = CustomEndpoint{Endpoint: url, SigningRegion: signingRegion}
} }
overridesActive = true overridesActive = true
} else {
overridesActive = false
}
return nil return nil
} }