From 2b3bb335690d77214e2c82dd64cd45e946f0112b Mon Sep 17 00:00:00 2001 From: Brendan Burns Date: Thu, 10 Sep 2015 13:07:13 -0700 Subject: [PATCH] Address comments. --- pkg/kubectl/custom_column_printer.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/kubectl/custom_column_printer.go b/pkg/kubectl/custom_column_printer.go index cc0dd5cd13e..e48003fac60 100644 --- a/pkg/kubectl/custom_column_printer.go +++ b/pkg/kubectl/custom_column_printer.go @@ -73,10 +73,10 @@ func massageJSONPath(pathExpression string) (string, error) { // NAME API_VERSION // foo bar func NewCustomColumnsPrinterFromSpec(spec string) (*CustomColumnsPrinter, error) { - parts := strings.Split(spec, ",") - if len(parts) == 0 { + if len(spec) == 0 { return nil, fmt.Errorf("custom-columns format specified but no custom columns given") } + parts := strings.Split(spec, ",") columns := make([]Column, len(parts)) for ix := range parts { colSpec := strings.Split(parts[ix], ":")