From 903c5a53b36d7952b60f397690ca472c6446f8ec Mon Sep 17 00:00:00 2001 From: SataQiu Date: Mon, 22 Apr 2019 11:46:45 +0800 Subject: [PATCH] fix shellcheck failures of cluster/gce/gci/shutdown.sh --- cluster/gce/gci/shutdown.sh | 2 +- hack/.shellcheck_failures | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/cluster/gce/gci/shutdown.sh b/cluster/gce/gci/shutdown.sh index dab0d34c62f..e50d4efefeb 100755 --- a/cluster/gce/gci/shutdown.sh +++ b/cluster/gce/gci/shutdown.sh @@ -16,7 +16,7 @@ # A script that let's gci preemptible nodes gracefully terminate in the event of a VM shutdown. preemptible=$(curl "http://metadata.google.internal/computeMetadata/v1/instance/scheduling/preemptible" -H "Metadata-Flavor: Google") -if [ ${preemptible} == "TRUE" ]; then +if [ "${preemptible}" == "TRUE" ]; then echo "Shutting down! Sleeping for a minute to let the node gracefully terminate" # https://cloud.google.com/compute/docs/instances/stopping-or-deleting-an-instance#delete_timeout sleep 30 diff --git a/hack/.shellcheck_failures b/hack/.shellcheck_failures index 09db2ed5e43..90730329d51 100644 --- a/hack/.shellcheck_failures +++ b/hack/.shellcheck_failures @@ -11,7 +11,6 @@ ./cluster/gce/gci/flexvolume_node_setup.sh ./cluster/gce/gci/health-monitor.sh ./cluster/gce/gci/master-helper.sh -./cluster/gce/gci/shutdown.sh ./cluster/gce/list-resources.sh ./cluster/gce/upgrade-aliases.sh ./cluster/gce/upgrade.sh