github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-24 20:24:09 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #130658 from tenzen-y/promote-successpolicy-e2e-to-conformance

Browse Source 
KEP-3998: Promote JobSuccessPolicy E2E to Conformance
This commit is contained in:
Kubernetes Prow Robot 2025-03-17 09:35:56 -07:00 committed by GitHub
commit 2cb9e77fde
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 41 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
test/conformance/testdata/conformance.yaml vendored
View File

@ -1154,6 +1154,32 @@
exceeds maxFailedIndexes.
release: v1.33
file: test/e2e/apps/job.go
- testname: Ensure that job with successPolicy succeeded when all indexes succeeded
codename: '[sig-apps] Job with successPolicy should succeeded when all indexes succeeded
[Conformance]'
description: Create an indexed job with successPolicy. Verify that job got SuccessCriteriaMet
with SuccessPolicy reason and Complete condition once all indexes succeeded.
release: v1.33
file: test/e2e/apps/job.go
- testname: Ensure that job with successPolicy succeededCount rule succeeded even
when some indexes remain pending
codename: '[sig-apps] Job with successPolicy succeededCount rule should succeeded
even when some indexes remain pending [Conformance]'
description: Create an indexed job with successPolicy succeededCount rule. Verify
that the job got the SuccessCriteriaMet with SuccessPolicy reason condition and
Complete condition when the job met successPolicy even if some indexed remain
pending.
release: v1.33
file: test/e2e/apps/job.go
- testname: Ensure that job with successPolicy succeededIndexes rule succeeded even
when some indexes remain pending
codename: '[sig-apps] Job with successPolicy succeededIndexes rule should succeeded
even when some indexes remain pending [Conformance]'
description: Create an indexed job with successPolicy succeededIndexes rule. Verify
that the job got SuccessCriteriaMet with SuccessPolicy reason condition and Complete
condition when the job met successPolicy even if some indexed remain pending.
release: v1.33
file: test/e2e/apps/job.go
- testname: ReplicaSet, is created, Replaced and Patched
codename: '[sig-apps] ReplicaSet Replace and Patch tests [Conformance]'
description: Create a ReplicaSet (RS) with a single Pod. The Pod MUST be verified

24
test/e2e/apps/job.go
View File

@ -476,12 +476,13 @@ done`}
})
/*
Testcase: Ensure that job with successPolicy succeeded when all indexes succeeded
Release: v1.33
Testname: Ensure that job with successPolicy succeeded when all indexes succeeded
Description: Create an indexed job with successPolicy.
Verify that job got SuccessCriteriaMet with SuccessPolicy reason and Complete condition
once all indexes succeeded.
*/
ginkgo.It("with successPolicy should succeeded when all indexes succeeded", func(ctx context.Context) {
framework.ConformanceIt("with successPolicy should succeeded when all indexes succeeded", func(ctx context.Context) {
parallelism := int32(2)
completions := int32(2)
backoffLimit := int32(6) // default value
@ -510,17 +511,19 @@ done`}
framework.ExpectNoError(err, "failed to get latest job object")
gomega.Expect(job.Status.Active).Should(gomega.Equal(int32(0)))
gomega.Expect(job.Status.Ready).Should(gomega.Equal(ptr.To[int32](0)))
gomega.Expect(job.Status.Terminating).Should(gomega.Equal(ptr.To[int32](0)))
// TODO (https://github.com/kubernetes/enhancements/issues/3939): Restore the assert on .status.terminating when PodReplacementPolicy goes GA.
// gomega.Expect(job.Status.Terminating).Should(gomega.Equal(ptr.To[int32](0)))
gomega.Expect(job.Status.Failed).Should(gomega.Equal(int32(0)))
})
/*
Testcase: Ensure that job with successPolicy succeededIndexes rule succeeded even when some indexes remain pending
Release: v1.33
Testname: Ensure that job with successPolicy succeededIndexes rule succeeded even when some indexes remain pending
Description: Create an indexed job with successPolicy succeededIndexes rule.
Verify that the job got SuccessCriteriaMet with SuccessPolicy reason condition and Complete condition
when the job met successPolicy even if some indexed remain pending.
*/
ginkgo.It("with successPolicy succeededIndexes rule should succeeded even when some indexes remain pending", func(ctx context.Context) {
framework.ConformanceIt("with successPolicy succeededIndexes rule should succeeded even when some indexes remain pending", func(ctx context.Context) {
parallelism := int32(2)
completions := int32(5)
backoffLimit := int32(6) // default value
@ -550,16 +553,18 @@ done`}
gomega.Expect(job.Status.CompletedIndexes).Should(gomega.Equal("0"))
gomega.Expect(job.Status.Active).Should(gomega.Equal(int32(0)))
gomega.Expect(job.Status.Ready).Should(gomega.Equal(ptr.To[int32](0)))
gomega.Expect(job.Status.Terminating).Should(gomega.Equal(ptr.To[int32](0)))
// TODO (https://github.com/kubernetes/enhancements/issues/3939): Restore the assert on .status.terminating when PodReplacementPolicy goes GA.
// gomega.Expect(job.Status.Terminating).Should(gomega.Equal(ptr.To[int32](0)))
})
/*
Testcase: Ensure that job with successPolicy succeededCount rule succeeded even when some indexes remain pending
Release: v1.33
Testname: Ensure that job with successPolicy succeededCount rule succeeded even when some indexes remain pending
Description: Create an indexed job with successPolicy succeededCount rule.
Verify that the job got the SuccessCriteriaMet with SuccessPolicy reason condition and Complete condition
when the job met successPolicy even if some indexed remain pending.
*/
ginkgo.It("with successPolicy succeededCount rule should succeeded even when some indexes remain pending", func(ctx context.Context) {
framework.ConformanceIt("with successPolicy succeededCount rule should succeeded even when some indexes remain pending", func(ctx context.Context) {
parallelism := int32(2)
completions := int32(5)
backoffLimit := int32(math.MaxInt32)
@ -589,7 +594,8 @@ done`}
gomega.Expect(job.Status.CompletedIndexes).Should(gomega.Equal("0"))
gomega.Expect(job.Status.Active).Should(gomega.Equal(int32(0)))
gomega.Expect(job.Status.Ready).Should(gomega.Equal(ptr.To[int32](0)))
gomega.Expect(job.Status.Terminating).Should(gomega.Equal(ptr.To[int32](0)))
// TODO (https://github.com/kubernetes/enhancements/issues/3939): Restore the assert on .status.terminating when PodReplacementPolicy goes GA.
// gomega.Expect(job.Status.Terminating).Should(gomega.Equal(ptr.To[int32](0)))
})
/*