github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-28 05:57:25 +00:00
Code Issues Projects Releases Wiki Activity

only create event for multiple imagegc failures

Browse Source
This commit is contained in:
David Ashpole 2017-03-12 06:42:11 -07:00
parent eaa386167a
commit 2cd65ea863
1 changed files with 11 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
pkg/kubelet/kubelet.go
View File

@ -1159,17 +1159,22 @@ func (kl *Kubelet) StartGarbageCollection() {
} }
}, ContainerGCPeriod, wait.NeverStop) }, ContainerGCPeriod, wait.NeverStop)
loggedImageGCFailure := false prevImageGCFailed := false
go wait.Until(func() { go wait.Until(func() {
if err := kl.imageManager.GarbageCollect(); err != nil { if err := kl.imageManager.GarbageCollect(); err != nil {
glog.Errorf("Image garbage collection failed: %v", err) if prevImageGCFailed {
kl.recorder.Eventf(kl.nodeRef, v1.EventTypeWarning, events.ImageGCFailed, err.Error()) glog.Errorf("Image garbage collection failed multiple times in a row: %v", err)
loggedImageGCFailure = true // Only create an event for repeated failures
kl.recorder.Eventf(kl.nodeRef, v1.EventTypeWarning, events.ImageGCFailed, err.Error())
} else {
glog.Errorf("Image garbage collection failed once. Stats initialization may not have completed yet: %v", err)
}
prevImageGCFailed = true
} else { } else {
var vLevel glog.Level = 4 var vLevel glog.Level = 4
if loggedImageGCFailure { if prevImageGCFailed {
vLevel = 1 vLevel = 1
loggedImageGCFailure = false prevImageGCFailed = false
} }
glog.V(vLevel).Infof("Image garbage collection succeeded") glog.V(vLevel).Infof("Image garbage collection succeeded")