From 2d05c3849a4540543e724dcfd761184723c42bf6 Mon Sep 17 00:00:00 2001 From: Patrick Ohly Date: Thu, 20 Mar 2025 13:36:21 +0100 Subject: [PATCH] DRA E2E: fix "cluster must manage ResourceSlices" test Adding SharedCounters broke the test and wasn't detected in the presubmit because the test is slow and didn't run. We could add a "SharedCounters is empty" clause, but probably it is safer to be less strict in the test and tolerate unknown fields. This will also minimize the work which needs to be done in the v1beta2 PR. --- test/e2e/dra/dra.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/test/e2e/dra/dra.go b/test/e2e/dra/dra.go index 826c5633cb0..fb58afb794a 100644 --- a/test/e2e/dra/dra.go +++ b/test/e2e/dra/dra.go @@ -1776,7 +1776,9 @@ var _ = framework.SIGDescribe("node")("DRA", feature.DynamicResourceAllocation, }), ), }), - "Spec": gstruct.MatchAllFields(gstruct.Fields{ + // Ignoring some fields, like SharedCounters, because we don't run this test + // for PRs (it's slow) and don't want CI breaks when fields get added or renamed. + "Spec": gstruct.MatchFields(gstruct.IgnoreExtras, gstruct.Fields{ "Driver": gomega.Equal(driver.Name), "NodeName": gomega.Equal(nodeName), "NodeSelector": gomega.BeNil(),