github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-23 19:56:01 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #35138 from MrHohn/kubedns-comment

Browse Source 
Automatic merge from submit-queue

Add comment for why EndpointsStore doesn't have DeleteFunc

I was confused about why EndpointsStore does not need to have the DeleteFunc. I think it would be helpful to have a comment here.

@bprashanth @bowei
This commit is contained in:
Kubernetes Submit Queue 2016-10-20 02:10:44 -07:00 committed by GitHub
commit 2d12c9ffca
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/dns/dns.go
View File

@ -225,6 +225,8 @@ func (kd *KubeDNS) setEndpointsStore() {
// TODO: Avoid unwanted updates.
kd.handleEndpointAdd(newObj)
},
// No DeleteFunc for EndpointsStore because endpoint object will be deleted
// when corresponding service is deleted.
},
)
}