Merge pull request #122866 from pohly/e2e-klog-fatal

e2e: replace klog.Fatal with assertion
This commit is contained in:
Kubernetes Prow Robot 2024-01-19 19:22:14 +01:00 committed by GitHub
commit 2d4100335e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 3 additions and 9 deletions

View File

@ -183,9 +183,7 @@ func setupSuite(ctx context.Context) {
}
c, err := framework.LoadClientset()
if err != nil {
klog.Fatal("Error loading client: ", err)
}
framework.ExpectNoError(err, "Error loading client")
// Delete any namespaces except those created by the system. This ensures no
// lingering resources are left over from a previous test run.
@ -380,9 +378,7 @@ func setupSuitePerGinkgoNode(ctx context.Context) {
// the dual stack clusters can be ipv4-ipv6 or ipv6-ipv4, order matters,
// and services use the primary IP family by default
c, err := framework.LoadClientset()
if err != nil {
klog.Fatal("Error loading client: ", err)
}
framework.ExpectNoError(err, "Error loading client")
framework.TestContext.IPFamily = getDefaultClusterIPFamily(ctx, c)
framework.Logf("Cluster IP family: %s", framework.TestContext.IPFamily)
}

View File

@ -549,9 +549,7 @@ func AfterReadingAllFlags(t *TestContextType) {
if len(t.BearerToken) == 0 {
var err error
t.BearerToken, err = GenerateSecureToken(16)
if err != nil {
klog.Fatalf("Failed to generate bearer token: %v", err)
}
ExpectNoError(err, "Failed to generate bearer token")
}
// Allow 1% of nodes to be unready (statistically) - relevant for large clusters.