From 23f75bf40e22f9582932d0dcf44b6416e1ecf6ba Mon Sep 17 00:00:00 2001 From: Dave Chen Date: Thu, 5 Jan 2023 16:15:44 +0800 Subject: [PATCH] kubeadm: fix the nil pointer dereference in testcase `genCSRConfig.kubeadmConfig` is possible to be nil if there any error from the config loading, so access the field should only be done if there is no error in the previous step. Signed-off-by: Dave Chen --- cmd/kubeadm/app/cmd/certs_test.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/cmd/kubeadm/app/cmd/certs_test.go b/cmd/kubeadm/app/cmd/certs_test.go index 073d7314990..40f6770b52d 100644 --- a/cmd/kubeadm/app/cmd/certs_test.go +++ b/cmd/kubeadm/app/cmd/certs_test.go @@ -464,11 +464,11 @@ kubernetesVersion: %s`, err := config.load() if test.expectErr { assert.Error(t, err) - } else { - assert.NoError(t, err) } - for _, assertFunc := range test.assertions { - assertFunc(t, config) + if !test.expectErr && assert.NoError(t, err) { + for _, assertFunc := range test.assertions { + assertFunc(t, config) + } } }) }