From bc16100549872b83536320d62b00715155f6ad97 Mon Sep 17 00:00:00 2001 From: Justin SB Date: Mon, 15 Feb 2021 19:01:32 -0500 Subject: [PATCH] tests: Set a 5 minute timeout for kubectl cluster-info dump We've observed this test causing e2e runs to time-out; the ginkgo behaviour here is unhelpful, in that we don't see any output on a timeout. Set a (generous) time limit to start to get output and enforce some limit to the response time. --- test/e2e/kubectl/kubectl.go | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/test/e2e/kubectl/kubectl.go b/test/e2e/kubectl/kubectl.go index acaf5651da4..ec578f666ac 100644 --- a/test/e2e/kubectl/kubectl.go +++ b/test/e2e/kubectl/kubectl.go @@ -1083,7 +1083,12 @@ metadata: ginkgo.Describe("Kubectl cluster-info dump", func() { ginkgo.It("should check if cluster-info dump succeeds", func() { ginkgo.By("running cluster-info dump") - framework.RunKubectlOrDie(ns, "cluster-info", "dump") + + // Should return in a timely fashion (or we should mark the test slow) + timer := time.NewTimer(300 * time.Second) + defer timer.Stop() + + framework.NewKubectlCommand(ns, "cluster-info", "dump").WithTimeout(timer.C).ExecOrDie(ns) }) })