From 2d868441d807d3f11be9541cc3c89d39cbd5dec3 Mon Sep 17 00:00:00 2001 From: Jordan Liggitt Date: Fri, 9 Dec 2016 09:59:58 -0500 Subject: [PATCH] Make sorting work on versioned objects --- pkg/kubectl/sorting_printer.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/pkg/kubectl/sorting_printer.go b/pkg/kubectl/sorting_printer.go index 3c1e2e37d51..00ddef76272 100644 --- a/pkg/kubectl/sorting_printer.go +++ b/pkg/kubectl/sorting_printer.go @@ -103,7 +103,9 @@ func SortObjects(decoder runtime.Decoder, objs []runtime.Object, fieldInput stri switch u := item.(type) { case *runtime.Unknown: var err error - if objs[ix], _, err = decoder.Decode(u.Raw, nil, nil); err != nil { + // decode runtime.Unknown to runtime.Unstructured for sorting. + // we don't actually want the internal versions of known types. + if objs[ix], _, err = decoder.Decode(u.Raw, nil, &runtime.Unstructured{}); err != nil { return nil, err } }