refine code

This commit is contained in:
Li Bo 2023-02-14 15:10:54 +08:00
parent c0bb425d8f
commit 2d98d2412a
3 changed files with 5 additions and 7 deletions

View File

@ -64,11 +64,9 @@ func (cfgCtlr *configController) dumpPriorityLevels(w http.ResponseWriter, r *ht
} }
tabPrint(tabWriter, rowForHeaders(columnHeaders)) tabPrint(tabWriter, rowForHeaders(columnHeaders))
endLine(tabWriter) endLine(tabWriter)
plNames := make([]string, len(cfgCtlr.priorityLevelStates)) plNames := make([]string, 0, len(cfgCtlr.priorityLevelStates))
i := 0
for plName := range cfgCtlr.priorityLevelStates { for plName := range cfgCtlr.priorityLevelStates {
plNames[i] = plName plNames = append(plNames, plName)
i++
} }
sort.Strings(plNames) sort.Strings(plNames)
for i := range plNames { for i := range plNames {

View File

@ -181,7 +181,7 @@ func (cfgCtlr *configController) Handle(ctx context.Context, requestDigest Reque
metrics.ObserveWaitingDuration(ctx, pl.Name, fs.Name, strconv.FormatBool(req != nil), time.Since(startWaitingTime)) metrics.ObserveWaitingDuration(ctx, pl.Name, fs.Name, strconv.FormatBool(req != nil), time.Since(startWaitingTime))
} }
metrics.AddDispatch(ctx, pl.Name, fs.Name) metrics.AddDispatch(ctx, pl.Name, fs.Name)
fqs.OnRequestDispatched(ctx, req) fqs.OnRequestDispatched(req)
executed = true executed = true
startExecutionTime := time.Now() startExecutionTime := time.Now()
defer func() { defer func() {

View File

@ -1071,7 +1071,7 @@ func (qs *queueSet) Dump(includeRequestDetails bool) debug.QueueSetDump {
return d return d
} }
func OnRequestDispatched(ctx context.Context, r fq.Request) { func OnRequestDispatched(r fq.Request) {
req, ok := r.(*request) req, ok := r.(*request)
if !ok { if !ok {
return return
@ -1079,7 +1079,7 @@ func OnRequestDispatched(ctx context.Context, r fq.Request) {
qs := req.qs qs := req.qs
if qs != nil { if qs != nil {
qs.lockAndSyncTime(ctx) qs.lock.Lock()
defer qs.lock.Unlock() defer qs.lock.Unlock()
qs.totRequestsDispatched++ qs.totRequestsDispatched++
} }