From 517feed45b5767a803552a3ad60925a09a4566a7 Mon Sep 17 00:00:00 2001 From: sanposhiho <44139130+sanposhiho@users.noreply.github.com> Date: Sun, 23 May 2021 23:48:42 +0900 Subject: [PATCH 1/2] Add: interface check --- pkg/scheduler/framework/plugins/nodeaffinity/node_affinity.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/pkg/scheduler/framework/plugins/nodeaffinity/node_affinity.go b/pkg/scheduler/framework/plugins/nodeaffinity/node_affinity.go index 27fa711b9b6..2c2476c2d43 100644 --- a/pkg/scheduler/framework/plugins/nodeaffinity/node_affinity.go +++ b/pkg/scheduler/framework/plugins/nodeaffinity/node_affinity.go @@ -36,8 +36,11 @@ type NodeAffinity struct { addedPrefSchedTerms *nodeaffinity.PreferredSchedulingTerms } +var _ framework.PreFilterPlugin = &NodeAffinity{} var _ framework.FilterPlugin = &NodeAffinity{} +var _ framework.PreScorePlugin = &NodeAffinity{} var _ framework.ScorePlugin = &NodeAffinity{} +var _ framework.ScoreExtensions = &NodeAffinity{} var _ framework.EnqueueExtensions = &NodeAffinity{} const ( From 1b6895c11fb6e0c380d4eccde933e397dd347193 Mon Sep 17 00:00:00 2001 From: sanposhiho <44139130+sanposhiho@users.noreply.github.com> Date: Tue, 25 May 2021 13:57:30 +0900 Subject: [PATCH 2/2] Fix: remove framework.ScoreExtensions interface check --- pkg/scheduler/framework/plugins/nodeaffinity/node_affinity.go | 1 - 1 file changed, 1 deletion(-) diff --git a/pkg/scheduler/framework/plugins/nodeaffinity/node_affinity.go b/pkg/scheduler/framework/plugins/nodeaffinity/node_affinity.go index 2c2476c2d43..41692823290 100644 --- a/pkg/scheduler/framework/plugins/nodeaffinity/node_affinity.go +++ b/pkg/scheduler/framework/plugins/nodeaffinity/node_affinity.go @@ -40,7 +40,6 @@ var _ framework.PreFilterPlugin = &NodeAffinity{} var _ framework.FilterPlugin = &NodeAffinity{} var _ framework.PreScorePlugin = &NodeAffinity{} var _ framework.ScorePlugin = &NodeAffinity{} -var _ framework.ScoreExtensions = &NodeAffinity{} var _ framework.EnqueueExtensions = &NodeAffinity{} const (