github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-14 14:23:37 +00:00
Code Issues Projects Releases Wiki Activity

node: cpumgr: logs: bump log verbosiness for expected skips

Browse Source 
In the reconciliation flow, there are expected skipping
conditions (e.g. for active logs). To reduce noise in the logs,
bump up the verbosiness of these messages, using odd levels.

Signed-off-by: Francesco Romani <fromani@redhat.com>
This commit is contained in:
Francesco Romani 2023-09-13 11:52:50 +02:00
parent 5a0bc1020b
commit 2dc5ddd08a
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
pkg/kubelet/cm/cpumanager/cpu_manager.go
View File

@ -381,7 +381,7 @@ func (m *manager) removeStaleState() {
for podUID := range assignments { for podUID := range assignments {
for containerName := range assignments[podUID] { for containerName := range assignments[podUID] {
if _, ok := activeContainers[podUID][containerName]; ok { if _, ok := activeContainers[podUID][containerName]; ok {
klog.V(4).InfoS("RemoveStaleState: container still active", "podUID", podUID, "containerName", containerName) klog.V(5).InfoS("RemoveStaleState: container still active", "podUID", podUID, "containerName", containerName)
continue continue
} }
klog.V(2).InfoS("RemoveStaleState: removing container", "podUID", podUID, "containerName", containerName) klog.V(2).InfoS("RemoveStaleState: removing container", "podUID", podUID, "containerName", containerName)
@ -394,7 +394,7 @@ func (m *manager) removeStaleState() {
m.containerMap.Visit(func(podUID, containerName, containerID string) { m.containerMap.Visit(func(podUID, containerName, containerID string) {
if _, ok := activeContainers[podUID][containerName]; ok { if _, ok := activeContainers[podUID][containerName]; ok {
klog.V(4).InfoS("RemoveStaleState: containerMap: container still active", "podUID", podUID, "containerName", containerName) klog.V(5).InfoS("RemoveStaleState: containerMap: container still active", "podUID", podUID, "containerName", containerName)
return return
} }
klog.V(2).InfoS("RemoveStaleState: containerMap: removing container", "podUID", podUID, "containerName", containerName) klog.V(2).InfoS("RemoveStaleState: containerMap: removing container", "podUID", podUID, "containerName", containerName)
@ -414,7 +414,7 @@ func (m *manager) reconcileState() (success []reconciledContainer, failure []rec
for _, pod := range m.activePods() { for _, pod := range m.activePods() {
pstatus, ok := m.podStatusProvider.GetPodStatus(pod.UID) pstatus, ok := m.podStatusProvider.GetPodStatus(pod.UID)
if !ok { if !ok {
klog.V(4).InfoS("ReconcileState: skipping pod; status not found", "pod", klog.KObj(pod)) klog.V(5).InfoS("ReconcileState: skipping pod; status not found", "pod", klog.KObj(pod))
failure = append(failure, reconciledContainer{pod.Name, "", ""}) failure = append(failure, reconciledContainer{pod.Name, "", ""})
continue continue
} }
@ -424,14 +424,14 @@ func (m *manager) reconcileState() (success []reconciledContainer, failure []rec
for _, container := range allContainers { for _, container := range allContainers {
containerID, err := findContainerIDByName(&pstatus, container.Name) containerID, err := findContainerIDByName(&pstatus, container.Name)
if err != nil { if err != nil {
klog.V(4).InfoS("ReconcileState: skipping container; ID not found in pod status", "pod", klog.KObj(pod), "containerName", container.Name, "err", err) klog.V(5).InfoS("ReconcileState: skipping container; ID not found in pod status", "pod", klog.KObj(pod), "containerName", container.Name, "err", err)
failure = append(failure, reconciledContainer{pod.Name, container.Name, ""}) failure = append(failure, reconciledContainer{pod.Name, container.Name, ""})
continue continue
} }
cstatus, err := findContainerStatusByName(&pstatus, container.Name) cstatus, err := findContainerStatusByName(&pstatus, container.Name)
if err != nil { if err != nil {
klog.V(4).InfoS("ReconcileState: skipping container; container status not found in pod status", "pod", klog.KObj(pod), "containerName", container.Name, "err", err) klog.V(5).InfoS("ReconcileState: skipping container; container status not found in pod status", "pod", klog.KObj(pod), "containerName", container.Name, "err", err)
failure = append(failure, reconciledContainer{pod.Name, container.Name, ""}) failure = append(failure, reconciledContainer{pod.Name, container.Name, ""})
continue continue
} }
@ -474,7 +474,7 @@ func (m *manager) reconcileState() (success []reconciledContainer, failure []rec
lcset := m.lastUpdateState.GetCPUSetOrDefault(string(pod.UID), container.Name) lcset := m.lastUpdateState.GetCPUSetOrDefault(string(pod.UID), container.Name)
if !cset.Equals(lcset) { if !cset.Equals(lcset) {
klog.V(4).InfoS("ReconcileState: updating container", "pod", klog.KObj(pod), "containerName", container.Name, "containerID", containerID, "cpuSet", cset) klog.V(5).InfoS("ReconcileState: updating container", "pod", klog.KObj(pod), "containerName", container.Name, "containerID", containerID, "cpuSet", cset)
err = m.updateContainerCPUSet(ctx, containerID, cset) err = m.updateContainerCPUSet(ctx, containerID, cset)
if err != nil { if err != nil {
klog.ErrorS(err, "ReconcileState: failed to update container", "pod", klog.KObj(pod), "containerName", container.Name, "containerID", containerID, "cpuSet", cset) klog.ErrorS(err, "ReconcileState: failed to update container", "pod", klog.KObj(pod), "containerName", container.Name, "containerID", containerID, "cpuSet", cset)