github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-29 14:37:00 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #56874 from caesarxuchao/fail-open-doc

Browse Source 
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Update the comments on webhook failure policy

ref: kubernetes/features#492

Note that comments on constants aren't reflected in the user docs
This commit is contained in:
Kubernetes Submit Queue 2018-01-25 11:44:42 -08:00 committed by GitHub
commit 2e3cb71583
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
pkg/apis/admissionregistration/types.go
View File

@ -106,11 +106,9 @@ type Rule struct {
type FailurePolicyType string type FailurePolicyType string
const ( const (
// Ignore means the initializer is removed from the initializers list of an // Ignore means that an error calling the webhook is ignored.
// object if the initializer is timed out.
Ignore FailurePolicyType = "Ignore" Ignore FailurePolicyType = "Ignore"
// For 1.7, only "Ignore" is allowed. "Fail" will be allowed when the // Fail means that an error calling the webhook causes the admission to fail.
// extensible admission feature is beta.
Fail FailurePolicyType = "Fail" Fail FailurePolicyType = "Fail"
) )

6
staging/src/k8s.io/api/admissionregistration/v1beta1/types.go
View File

@ -54,11 +54,9 @@ type Rule struct {
type FailurePolicyType string type FailurePolicyType string
const ( const (
// Ignore means the initializer is removed from the initializers list of an // Ignore means that an error calling the webhook is ignored.
// object if the initializer is timed out.
Ignore FailurePolicyType = "Ignore" Ignore FailurePolicyType = "Ignore"
// For 1.7, only "Ignore" is allowed. "Fail" will be allowed when the // Fail means that an error calling the webhook causes the admission to fail.
// extensible admission feature is beta.
Fail FailurePolicyType = "Fail" Fail FailurePolicyType = "Fail"
) )