From 6b18285cd2fc8fadec19624ffc3a75c91d1f9dab Mon Sep 17 00:00:00 2001 From: Ryan Phillips Date: Wed, 4 Sep 2019 10:01:52 -0500 Subject: [PATCH] kubelet e2e: defer the close to after the error check fixes a potential crash --- test/e2e/common/kubelet.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/e2e/common/kubelet.go b/test/e2e/common/kubelet.go index bf6fb3e25c6..d315b881cf5 100644 --- a/test/e2e/common/kubelet.go +++ b/test/e2e/common/kubelet.go @@ -168,10 +168,10 @@ var _ = framework.KubeDescribe("Kubelet", func() { gomega.Eventually(func() error { rc, err := podClient.GetLogs(podName, &v1.PodLogOptions{}).Stream() - defer rc.Close() if err != nil { return err } + defer rc.Close() buf := new(bytes.Buffer) buf.ReadFrom(rc) hostsFileContent := buf.String()