github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-05 18:24:07 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #120291 from lzhecheng/fix-credentialprovider-win-bin-path

Browse Source 
Fix Windows credential provider cannot find binary
This commit is contained in:
Kubernetes Prow Robot 2024-01-04 17:58:54 +01:00 committed by GitHub
commit 2efed1f1cb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
pkg/credentialprovider/plugin/plugin.go
View File

@ -98,8 +98,10 @@ func RegisterCredentialProviderPlugins(pluginConfigFile, pluginBinDir string) er
registerMetrics() registerMetrics()
for _, provider := range credentialProviderConfig.Providers { for _, provider := range credentialProviderConfig.Providers {
pluginBin := filepath.Join(pluginBinDir, provider.Name) // Considering Windows binary with suffix ".exe", LookPath() helps to find the correct path.
if _, err := os.Stat(pluginBin); err != nil { // LookPath() also calls os.Stat().
pluginBin, err := exec.LookPath(filepath.Join(pluginBinDir, provider.Name))
if err != nil {
if os.IsNotExist(err) { if os.IsNotExist(err) {
return fmt.Errorf("plugin binary executable %s did not exist", pluginBin) return fmt.Errorf("plugin binary executable %s did not exist", pluginBin)
} }