From 2f0a6d2c76471bbe0557c6296f8fc04cc110b36c Mon Sep 17 00:00:00 2001 From: Francesco Romani Date: Mon, 10 Feb 2020 18:51:59 +0100 Subject: [PATCH] e2e: topomgr: use constants for test limits Signed-off-by: Francesco Romani --- test/e2e_node/topology_manager_test.go | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/test/e2e_node/topology_manager_test.go b/test/e2e_node/topology_manager_test.go index 0e952c694bf..f7a0a6711eb 100644 --- a/test/e2e_node/topology_manager_test.go +++ b/test/e2e_node/topology_manager_test.go @@ -47,6 +47,9 @@ import ( const ( numalignCmd = `export CPULIST_ALLOWED=$( awk -F":\t*" '/Cpus_allowed_list/ { print $2 }' /proc/self/status); env; sleep 1d` + + minNumaNodes = 2 + minCoreCount = 4 ) // Helper for makeTopologyManagerPod(). @@ -707,10 +710,10 @@ func runTopologyManagerTests(f *framework.Framework) { numaNodes := detectNUMANodes() coreCount := detectCoresPerSocket() - if numaNodes < 2 { + if numaNodes < minNumaNodes { e2eskipper.Skipf("this test is meant to run on a multi-node NUMA system") } - if coreCount < 4 { + if coreCount < minCoreCount { e2eskipper.Skipf("this test is meant to run on a system with at least 4 cores per socket") } if sriovdevCount == 0 {