Fix dry run client ignore namespace

staging/src/k8s.io/cli-runtime/pkg/genericclioptions/config_flags_fake.go

@@ -96,7 +96,7 @@ type namespacedClientConfig struct {
 }
 
 func (c *namespacedClientConfig) Namespace() (string, bool, error) {
-	return c.namespace, false, nil
+	return c.namespace, len(c.namespace) > 0, nil
 }
 
 func (c *namespacedClientConfig) RawConfig() (clientcmdapi.Config, error) {

staging/src/k8s.io/kubectl/pkg/cmd/create/create_cronjob.go

@@ -59,6 +59,7 @@ type CreateCronJobOptions struct {
 	Restart  string
 
 	Namespace        string
+	EnforceNamespace bool
 	Client           batchv1beta1client.BatchV1beta1Interface
 	DryRunStrategy   cmdutil.DryRunStrategy
 	DryRunVerifier   *resource.DryRunVerifier
@@ -126,7 +127,7 @@ func (o *CreateCronJobOptions) Complete(f cmdutil.Factory, cmd *cobra.Command, a
 		return err
 	}
 
-	o.Namespace, _, err = f.ToRawKubeConfigLoader().Namespace()
+	o.Namespace, o.EnforceNamespace, err = f.ToRawKubeConfigLoader().Namespace()
 	if err != nil {
 		return err
 	}
@@ -193,7 +194,7 @@ func (o *CreateCronJobOptions) Run() error {
 }
 
 func (o *CreateCronJobOptions) createCronJob() *batchv1beta1.CronJob {
-	return &batchv1beta1.CronJob{
+	cronjob := &batchv1beta1.CronJob{
 		TypeMeta: metav1.TypeMeta{APIVersion: batchv1beta1.SchemeGroupVersion.String(), Kind: "CronJob"},
 		ObjectMeta: metav1.ObjectMeta{
 			Name: o.Name,
@@ -221,4 +222,8 @@ func (o *CreateCronJobOptions) createCronJob() *batchv1beta1.CronJob {
 			},
 		},
 	}
+	if o.EnforceNamespace {
+		cronjob.Namespace = o.Namespace
+	}
+	return cronjob
 }

staging/src/k8s.io/kubectl/pkg/cmd/create/create_job.go

@@ -63,6 +63,7 @@ type CreateJobOptions struct {
 	Command []string
 
 	Namespace        string
+	EnforceNamespace bool
 	Client           batchv1client.BatchV1Interface
 	DryRunStrategy   cmdutil.DryRunStrategy
 	DryRunVerifier   *resource.DryRunVerifier
@@ -126,7 +127,7 @@ func (o *CreateJobOptions) Complete(f cmdutil.Factory, cmd *cobra.Command, args
 		return err
 	}
 
-	o.Namespace, _, err = f.ToRawKubeConfigLoader().Namespace()
+	o.Namespace, o.EnforceNamespace, err = f.ToRawKubeConfigLoader().Namespace()
 	if err != nil {
 		return err
 	}
@@ -222,7 +223,7 @@ func (o *CreateJobOptions) Run() error {
 }
 
 func (o *CreateJobOptions) createJob() *batchv1.Job {
-	return &batchv1.Job{
+	job := &batchv1.Job{
 		// this is ok because we know exactly how we want to be serialized
 		TypeMeta: metav1.TypeMeta{APIVersion: batchv1.SchemeGroupVersion.String(), Kind: "Job"},
 		ObjectMeta: metav1.ObjectMeta{
@@ -243,6 +244,10 @@ func (o *CreateJobOptions) createJob() *batchv1.Job {
 			},
 		},
 	}
+	if o.EnforceNamespace {
+		job.Namespace = o.Namespace
+	}
+	return job
 }
 
 func (o *CreateJobOptions) createJobFromCronJob(cronJob *batchv1beta1.CronJob) *batchv1.Job {
@@ -252,7 +257,7 @@ func (o *CreateJobOptions) createJobFromCronJob(cronJob *batchv1beta1.CronJob) *
 		annotations[k] = v
 	}
 
-	return &batchv1.Job{
+	job := &batchv1.Job{
 		// this is ok because we know exactly how we want to be serialized
 		TypeMeta: metav1.TypeMeta{APIVersion: batchv1.SchemeGroupVersion.String(), Kind: "Job"},
 		ObjectMeta: metav1.ObjectMeta{
@@ -270,4 +275,8 @@ func (o *CreateJobOptions) createJobFromCronJob(cronJob *batchv1beta1.CronJob) *
 		},
 		Spec: cronJob.Spec.JobTemplate.Spec,
 	}
+	if o.EnforceNamespace {
+		job.Namespace = o.Namespace
+	}
+	return job
 }

staging/src/k8s.io/kubectl/pkg/cmd/create/create_role.go

@@ -131,6 +131,7 @@ type CreateRoleOptions struct {
 	DryRunVerifier   *resource.DryRunVerifier
 	OutputFormat     string
 	Namespace        string
+	EnforceNamespace bool
 	Client           clientgorbacv1.RbacV1Interface
 	Mapper           meta.RESTMapper
 	PrintObj         func(obj runtime.Object) error
@@ -263,7 +264,7 @@ func (o *CreateRoleOptions) Complete(f cmdutil.Factory, cmd *cobra.Command, args
 		return printer.PrintObj(obj, o.Out)
 	}
 
-	o.Namespace, _, err = f.ToRawKubeConfigLoader().Namespace()
+	o.Namespace, o.EnforceNamespace, err = f.ToRawKubeConfigLoader().Namespace()
 	if err != nil {
 		return err
 	}
@@ -352,6 +353,9 @@ func (o *CreateRoleOptions) RunCreateRole() error {
 		return err
 	}
 	role.Rules = rules
+	if o.EnforceNamespace {
+		role.Namespace = o.Namespace
+	}
 
 	// Create role.
 	if o.DryRunStrategy != cmdutil.DryRunClient {

staging/src/k8s.io/kubectl/pkg/cmd/create/create_role_test.go

@@ -33,8 +33,8 @@ import (
 
 func TestCreateRole(t *testing.T) {
 	roleName := "my-role"
-
+	testNameSpace := "test"
-	tf := cmdtesting.NewTestFactory().WithNamespace("test")
+	tf := cmdtesting.NewTestFactory().WithNamespace(testNameSpace)
 	defer tf.Cleanup()
 
 	tf.Client = &fake.RESTClient{}
@@ -53,6 +53,7 @@ func TestCreateRole(t *testing.T) {
 				TypeMeta: v1.TypeMeta{APIVersion: "rbac.authorization.k8s.io/v1", Kind: "Role"},
 				ObjectMeta: v1.ObjectMeta{
 					Name:      roleName,
+					Namespace: testNameSpace,
 				},
 				Rules: []rbac.PolicyRule{
 					{
@@ -71,6 +72,7 @@ func TestCreateRole(t *testing.T) {
 				TypeMeta: v1.TypeMeta{APIVersion: "rbac.authorization.k8s.io/v1", Kind: "Role"},
 				ObjectMeta: v1.ObjectMeta{
 					Name:      roleName,
+					Namespace: testNameSpace,
 				},
 				Rules: []rbac.PolicyRule{
 					{
@@ -89,6 +91,7 @@ func TestCreateRole(t *testing.T) {
 				TypeMeta: v1.TypeMeta{APIVersion: "rbac.authorization.k8s.io/v1", Kind: "Role"},
 				ObjectMeta: v1.ObjectMeta{
 					Name:      roleName,
+					Namespace: testNameSpace,
 				},
 				Rules: []rbac.PolicyRule{
 					{
@@ -107,6 +110,7 @@ func TestCreateRole(t *testing.T) {
 				TypeMeta: v1.TypeMeta{APIVersion: "rbac.authorization.k8s.io/v1", Kind: "Role"},
 				ObjectMeta: v1.ObjectMeta{
 					Name:      roleName,
+					Namespace: testNameSpace,
 				},
 				Rules: []rbac.PolicyRule{
 					{

staging/src/k8s.io/kubectl/pkg/cmd/set/set_env_test.go

@@ -79,7 +79,7 @@ func TestSetEnvLocal(t *testing.T) {
 }
 
 func TestSetEnvLocalNamespace(t *testing.T) {
-	tf := cmdtesting.NewTestFactory().WithNamespace("test")
+	tf := cmdtesting.NewTestFactory()
 	defer tf.Cleanup()
 
 	tf.Client = &fake.RESTClient{