From d9545976ede823bc96ca00292ed1652ff94a694a Mon Sep 17 00:00:00 2001 From: wlq1212 Date: Wed, 11 Oct 2023 19:30:06 +0800 Subject: [PATCH] using wait.Interrupted instead of deprecated wait.ErrWaitTimeout for utils --- test/utils/deployment.go | 8 ++++---- test/utils/replicaset.go | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/test/utils/deployment.go b/test/utils/deployment.go index b7bb7b7fe59..60f20751a8a 100644 --- a/test/utils/deployment.go +++ b/test/utils/deployment.go @@ -105,7 +105,7 @@ func waitForDeploymentCompleteMaybeCheckRolling(c clientset.Interface, d *apps.D return false, nil }) - if err == wait.ErrWaitTimeout { + if wait.Interrupted(err) { err = fmt.Errorf("%s", reason) } if err != nil { @@ -224,7 +224,7 @@ func WaitForDeploymentRevisionAndImage(c clientset.Interface, ns, deploymentName } return true, nil }) - if err == wait.ErrWaitTimeout { + if wait.Interrupted(err) { LogReplicaSetsOfDeployment(deployment, nil, newRS, logf) err = fmt.Errorf(reason) } @@ -316,7 +316,7 @@ func UpdateDeploymentWithRetries(c clientset.Interface, namespace, name string, updateErr = err return false, nil }) - if pollErr == wait.ErrWaitTimeout { + if wait.Interrupted(pollErr) { pollErr = fmt.Errorf("couldn't apply the provided updated to deployment %q: %v", name, updateErr) } return deployment, pollErr @@ -375,7 +375,7 @@ func WaitForDeploymentWithCondition(c clientset.Interface, ns, deploymentName, r cond := deploymentutil.GetDeploymentCondition(deployment.Status, condType) return cond != nil && cond.Reason == reason, nil }) - if pollErr == wait.ErrWaitTimeout { + if wait.Interrupted(pollErr) { pollErr = fmt.Errorf("deployment %q never updated with the desired condition and reason, latest deployment conditions: %+v", deployment.Name, deployment.Status.Conditions) _, allOldRSs, newRS, err := GetAllReplicaSets(deployment, c) if err == nil { diff --git a/test/utils/replicaset.go b/test/utils/replicaset.go index 625d6c7cc83..ffaa6b3a5a6 100644 --- a/test/utils/replicaset.go +++ b/test/utils/replicaset.go @@ -47,7 +47,7 @@ func UpdateReplicaSetWithRetries(c clientset.Interface, namespace, name string, updateErr = err return false, nil }) - if pollErr == wait.ErrWaitTimeout { + if wait.Interrupted(pollErr) { pollErr = fmt.Errorf("couldn't apply the provided updated to replicaset %q: %v", name, updateErr) } return rs, pollErr @@ -85,7 +85,7 @@ func UpdateReplicaSetStatusWithRetries(c clientset.Interface, namespace, name st updateErr = err return false, nil }) - if pollErr == wait.ErrWaitTimeout { + if wait.Interrupted(pollErr) { pollErr = fmt.Errorf("couldn't apply the provided update to replicaset %q: %v", name, updateErr) } return rs, pollErr