From 2fd76c8ed184df3e5e5601754402da60c6cfc403 Mon Sep 17 00:00:00 2001 From: yongruilin Date: Wed, 1 Oct 2025 21:38:57 +0000 Subject: [PATCH] fix: Comment out ipSloppyValidator It is currently not supported. --- .../cmd/validation-gen/validators/format.go | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/staging/src/k8s.io/code-generator/cmd/validation-gen/validators/format.go b/staging/src/k8s.io/code-generator/cmd/validation-gen/validators/format.go index 2f7cc15988f..aa6612f826d 100644 --- a/staging/src/k8s.io/code-generator/cmd/validation-gen/validators/format.go +++ b/staging/src/k8s.io/code-generator/cmd/validation-gen/validators/format.go @@ -49,7 +49,9 @@ func (formatTagValidator) ValidScopes() sets.Set[Scope] { var ( // Keep this list alphabetized. - ipSloppyValidator = types.Name{Package: libValidationPkg, Name: "IPSloppy"} + // TODO: uncomment the following when we've done the homework + // to be sure it works the current state of IP manual-ratcheting + // ipSloppyValidator = types.Name{Package: libValidationPkg, Name: "IPSloppy"} labelKeyValidator = types.Name{Package: libValidationPkg, Name: "LabelKey"} labelValueValidator = types.Name{Package: libValidationPkg, Name: "LabelValue"} longNameCaselessValidator = types.Name{Package: libValidationPkg, Name: "LongNameCaseless"} @@ -83,8 +85,12 @@ func getFormatValidationFunction(format string) (FunctionGen, error) { switch format { // Keep this sequence alphabetized. - case "k8s-ip": - return Function(formatTagName, DefaultFlags, ipSloppyValidator), nil + // TODO: uncomment the following when we've done the homework + // to be sure it works the current state of IP manual-ratcheting + /* + case "k8s-ip": + return Function(formatTagName, DefaultFlags, ipSloppyValidator), nil + */ case "k8s-label-key": return Function(formatTagName, DefaultFlags, labelKeyValidator), nil case "k8s-label-value":