From 93aa0b056eb9fc7091fee81a0cde1aada467c24d Mon Sep 17 00:00:00 2001 From: Antonio Ojea Date: Mon, 9 Sep 2024 11:06:33 +0000 Subject: [PATCH 1/2] add feature gate to ServiceCIDR e2e test --- test/e2e/network/service_cidrs.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/e2e/network/service_cidrs.go b/test/e2e/network/service_cidrs.go index 5a80fc51393..8b7b5facbb2 100644 --- a/test/e2e/network/service_cidrs.go +++ b/test/e2e/network/service_cidrs.go @@ -26,6 +26,7 @@ import ( "k8s.io/apimachinery/pkg/util/intstr" "k8s.io/apimachinery/pkg/util/wait" clientset "k8s.io/client-go/kubernetes" + "k8s.io/kubernetes/pkg/features" "k8s.io/kubernetes/test/e2e/feature" "k8s.io/kubernetes/test/e2e/framework" e2enode "k8s.io/kubernetes/test/e2e/framework/node" @@ -36,7 +37,7 @@ import ( admissionapi "k8s.io/pod-security-admission/api" ) -var _ = common.SIGDescribe(feature.ServiceCIDRs, func() { +var _ = common.SIGDescribe(feature.ServiceCIDRs, framework.WithFeatureGate(features.MultiCIDRServiceAllocator), func() { fr := framework.NewDefaultFramework("servicecidrs") fr.NamespacePodSecurityEnforceLevel = admissionapi.LevelPrivileged From 2c38ae726a8fa1cb58f92ebda7353a8e4dc6cfe6 Mon Sep 17 00:00:00 2001 From: Antonio Ojea Date: Mon, 9 Sep 2024 11:06:52 +0000 Subject: [PATCH 2/2] fix typo on ServiceCIDR e2e test title --- test/e2e/network/service_cidrs.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/e2e/network/service_cidrs.go b/test/e2e/network/service_cidrs.go index 8b7b5facbb2..c768d7fa9ea 100644 --- a/test/e2e/network/service_cidrs.go +++ b/test/e2e/network/service_cidrs.go @@ -61,7 +61,7 @@ var _ = common.SIGDescribe(feature.ServiceCIDRs, framework.WithFeatureGate(featu }) - ginkgo.It("should create Services and servce on different Service CIDRs", func(ctx context.Context) { + ginkgo.It("should create Services and serve on different Service CIDRs", func(ctx context.Context) { // create a new service CIDR svcCIDR := &networkingv1beta1.ServiceCIDR{ ObjectMeta: metav1.ObjectMeta{