From b086d296def97cc445114023669a4ed3ab3eaf21 Mon Sep 17 00:00:00 2001 From: tanjunchen <2799194073@qq.com> Date: Tue, 24 Dec 2019 10:32:15 +0800 Subject: [PATCH] move funcs in replicaset to autoscaling_utils --- test/e2e/framework/autoscaling/BUILD | 1 - test/e2e/framework/autoscaling/autoscaling_utils.go | 11 +++++++++-- test/e2e/framework/replicaset/BUILD | 2 -- test/e2e/framework/replicaset/wait.go | 11 ----------- 4 files changed, 9 insertions(+), 16 deletions(-) diff --git a/test/e2e/framework/autoscaling/BUILD b/test/e2e/framework/autoscaling/BUILD index 21552459353..d85a0decf92 100644 --- a/test/e2e/framework/autoscaling/BUILD +++ b/test/e2e/framework/autoscaling/BUILD @@ -18,7 +18,6 @@ go_library( "//test/e2e/framework:go_default_library", "//test/e2e/framework/kubectl:go_default_library", "//test/e2e/framework/rc:go_default_library", - "//test/e2e/framework/replicaset:go_default_library", "//test/e2e/framework/service:go_default_library", "//test/utils:go_default_library", "//test/utils/image:go_default_library", diff --git a/test/e2e/framework/autoscaling/autoscaling_utils.go b/test/e2e/framework/autoscaling/autoscaling_utils.go index 90f527a5d9f..b33b5f89a4f 100644 --- a/test/e2e/framework/autoscaling/autoscaling_utils.go +++ b/test/e2e/framework/autoscaling/autoscaling_utils.go @@ -34,7 +34,6 @@ import ( "k8s.io/kubernetes/test/e2e/framework" e2ekubectl "k8s.io/kubernetes/test/e2e/framework/kubectl" e2erc "k8s.io/kubernetes/test/e2e/framework/rc" - "k8s.io/kubernetes/test/e2e/framework/replicaset" e2eservice "k8s.io/kubernetes/test/e2e/framework/service" testutils "k8s.io/kubernetes/test/utils" @@ -494,7 +493,7 @@ func runServiceAndWorkloadForResourceConsumer(c clientset.Interface, ns, name st RCConfig: rcConfig, } ginkgo.By(fmt.Sprintf("creating replicaset %s in namespace %s", rsConfig.Name, rsConfig.Namespace)) - framework.ExpectNoError(replicaset.RunReplicaSet(rsConfig)) + framework.ExpectNoError(runReplicaSet(rsConfig)) default: framework.Failf(invalidKind) } @@ -564,3 +563,11 @@ func CreateCPUHorizontalPodAutoscaler(rc *ResourceConsumer, cpu, minReplicas, ma func DeleteHorizontalPodAutoscaler(rc *ResourceConsumer, autoscalerName string) { rc.clientSet.AutoscalingV1().HorizontalPodAutoscalers(rc.nsName).Delete(autoscalerName, nil) } + +// runReplicaSet launches (and verifies correctness) of a replicaset. +func runReplicaSet(config testutils.ReplicaSetConfig) error { + ginkgo.By(fmt.Sprintf("creating replicaset %s in namespace %s", config.Name, config.Namespace)) + config.NodeDumpFunc = framework.DumpNodeDebugInfo + config.ContainerDumpFunc = e2ekubectl.LogFailedContainers + return testutils.RunReplicaSet(config) +} diff --git a/test/e2e/framework/replicaset/BUILD b/test/e2e/framework/replicaset/BUILD index 0e3e70badf7..9b5c0996156 100644 --- a/test/e2e/framework/replicaset/BUILD +++ b/test/e2e/framework/replicaset/BUILD @@ -16,9 +16,7 @@ go_library( "//staging/src/k8s.io/apimachinery/pkg/util/wait:go_default_library", "//staging/src/k8s.io/client-go/kubernetes:go_default_library", "//test/e2e/framework:go_default_library", - "//test/e2e/framework/kubectl:go_default_library", "//test/utils:go_default_library", - "//vendor/github.com/onsi/ginkgo:go_default_library", ], ) diff --git a/test/e2e/framework/replicaset/wait.go b/test/e2e/framework/replicaset/wait.go index c004d3a2960..d214d0cba00 100644 --- a/test/e2e/framework/replicaset/wait.go +++ b/test/e2e/framework/replicaset/wait.go @@ -19,24 +19,13 @@ package replicaset import ( "fmt" - "github.com/onsi/ginkgo" appsv1 "k8s.io/api/apps/v1" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" "k8s.io/apimachinery/pkg/util/wait" clientset "k8s.io/client-go/kubernetes" "k8s.io/kubernetes/test/e2e/framework" - e2ekubectl "k8s.io/kubernetes/test/e2e/framework/kubectl" - testutils "k8s.io/kubernetes/test/utils" ) -// RunReplicaSet launches (and verifies correctness) of a replicaset. -func RunReplicaSet(config testutils.ReplicaSetConfig) error { - ginkgo.By(fmt.Sprintf("creating replicaset %s in namespace %s", config.Name, config.Namespace)) - config.NodeDumpFunc = framework.DumpNodeDebugInfo - config.ContainerDumpFunc = e2ekubectl.LogFailedContainers - return testutils.RunReplicaSet(config) -} - // WaitForReadyReplicaSet waits until the replicaset has all of its replicas ready. func WaitForReadyReplicaSet(c clientset.Interface, ns, name string) error { err := wait.Poll(framework.Poll, framework.PollShortTimeout, func() (bool, error) {