From 633a72ce2845ab0e0bb0ad4808cf0df600db1bf1 Mon Sep 17 00:00:00 2001 From: Caleb Woodbine Date: Wed, 12 Feb 2020 09:19:37 +1300 Subject: [PATCH 1/8] Promote: PodTemplate Lifecycle test --- test/conformance/testdata/conformance.yaml | 9 +++++++++ test/e2e/common/podtemplates.go | 9 +++++++-- 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/test/conformance/testdata/conformance.yaml b/test/conformance/testdata/conformance.yaml index d69a8d3c366..9c97e15dbe3 100755 --- a/test/conformance/testdata/conformance.yaml +++ b/test/conformance/testdata/conformance.yaml @@ -1234,6 +1234,15 @@ StorageClass or a dynamic provisioner. release: v1.9 file: test/e2e/apps/statefulset.go +- testname: ConfigMap lifecycle + codename: '[sig-architecture] PodTemplates should run the lifecycle of PodTemplates + [Conformance]' + description: Attempt to create a ConfigMap. Patch the created ConfigMap. Fetching + the ConfigMap MUST reflect changes. By fetching all the ConfigMaps via a Label + selector it MUST find the ConfigMap by it's static label and updated value. The + ConfigMap must be deleted by Collection. + release: v1.18 + file: test/e2e/common/podtemplates.go - testname: Service account tokens auto mount optionally codename: '[sig-auth] ServiceAccounts should allow opting out of API token automount [Conformance]' description: Ensure that Service Account keys are mounted into the Pod only when diff --git a/test/e2e/common/podtemplates.go b/test/e2e/common/podtemplates.go index f289797466c..3951a613481 100644 --- a/test/e2e/common/podtemplates.go +++ b/test/e2e/common/podtemplates.go @@ -31,8 +31,13 @@ import ( var _ = ginkgo.Describe("[sig-architecture] PodTemplates", func() { f := framework.NewDefaultFramework("podtemplate") - - ginkgo.It("should run the lifecycle of PodTemplates", func() { + /* + Release : v1.18 + Testname: ConfigMap lifecycle + Description: Attempt to create a ConfigMap. Patch the created ConfigMap. Fetching the ConfigMap MUST reflect changes. + By fetching all the ConfigMaps via a Label selector it MUST find the ConfigMap by it's static label and updated value. The ConfigMap must be deleted by Collection. + */ + framework.ConformanceIt("should run the lifecycle of PodTemplates", func() { testNamespaceName := f.Namespace.Name podTemplateName := "nginx-pod-template-" + string(uuid.NewUUID()) From 22f8a698ffcfd8e25110d4f27b6de93aa990534e Mon Sep 17 00:00:00 2001 From: Caleb Woodbine Date: Thu, 20 Feb 2020 08:27:39 +1300 Subject: [PATCH 2/8] Fix: metadata --- test/e2e/common/podtemplates.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/e2e/common/podtemplates.go b/test/e2e/common/podtemplates.go index 3951a613481..9fbc0559d6a 100644 --- a/test/e2e/common/podtemplates.go +++ b/test/e2e/common/podtemplates.go @@ -33,9 +33,9 @@ var _ = ginkgo.Describe("[sig-architecture] PodTemplates", func() { f := framework.NewDefaultFramework("podtemplate") /* Release : v1.18 - Testname: ConfigMap lifecycle - Description: Attempt to create a ConfigMap. Patch the created ConfigMap. Fetching the ConfigMap MUST reflect changes. - By fetching all the ConfigMaps via a Label selector it MUST find the ConfigMap by it's static label and updated value. The ConfigMap must be deleted by Collection. + Testname: PodTemplate lifecycle + Description: Attempt to create a PodTemplate. Patch the created PodTemplate. Fetching the PodTemplate MUST reflect changes. + By fetching all the PodTemplates via a Label selector it MUST find the PodTemplate by it's static label and updated value. The PodTemplate must be deleted by Collection. */ framework.ConformanceIt("should run the lifecycle of PodTemplates", func() { testNamespaceName := f.Namespace.Name From 947584d3b40d961db7588006950f39f26167fb93 Mon Sep 17 00:00:00 2001 From: Caleb Woodbine Date: Wed, 26 Feb 2020 10:54:24 +1300 Subject: [PATCH 3/8] Fix metadata description --- test/e2e/common/podtemplates.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/e2e/common/podtemplates.go b/test/e2e/common/podtemplates.go index 9fbc0559d6a..5bf3939ed3a 100644 --- a/test/e2e/common/podtemplates.go +++ b/test/e2e/common/podtemplates.go @@ -35,7 +35,7 @@ var _ = ginkgo.Describe("[sig-architecture] PodTemplates", func() { Release : v1.18 Testname: PodTemplate lifecycle Description: Attempt to create a PodTemplate. Patch the created PodTemplate. Fetching the PodTemplate MUST reflect changes. - By fetching all the PodTemplates via a Label selector it MUST find the PodTemplate by it's static label and updated value. The PodTemplate must be deleted by Collection. + By fetching all the PodTemplates via a Label selector it MUST find the PodTemplate by it's static label and updated value. The PodTemplate must be deleted. */ framework.ConformanceIt("should run the lifecycle of PodTemplates", func() { testNamespaceName := f.Namespace.Name From c33e3bdc28d31b69440837a46ab4b5bddf3d0fe5 Mon Sep 17 00:00:00 2001 From: Caleb Woodbine Date: Mon, 2 Mar 2020 14:17:24 +1300 Subject: [PATCH 4/8] Fix conformance testdata --- test/conformance/testdata/conformance.yaml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/test/conformance/testdata/conformance.yaml b/test/conformance/testdata/conformance.yaml index 9c97e15dbe3..36f83768091 100755 --- a/test/conformance/testdata/conformance.yaml +++ b/test/conformance/testdata/conformance.yaml @@ -1234,13 +1234,13 @@ StorageClass or a dynamic provisioner. release: v1.9 file: test/e2e/apps/statefulset.go -- testname: ConfigMap lifecycle +- testname: PodTemplate lifecycle codename: '[sig-architecture] PodTemplates should run the lifecycle of PodTemplates [Conformance]' - description: Attempt to create a ConfigMap. Patch the created ConfigMap. Fetching - the ConfigMap MUST reflect changes. By fetching all the ConfigMaps via a Label - selector it MUST find the ConfigMap by it's static label and updated value. The - ConfigMap must be deleted by Collection. + description: Attempt to create a PodTemplate. Patch the created PodTemplate. Fetching + the PodTemplate MUST reflect changes. By fetching all the PodTemplates via a Label + selector it MUST find the PodTemplate by it's static label and updated value. + The PodTemplate must be deleted. release: v1.18 file: test/e2e/common/podtemplates.go - testname: Service account tokens auto mount optionally From fce812b5029edc57636cb80874d08982afe77f92 Mon Sep 17 00:00:00 2001 From: Caleb Woodbine Date: Wed, 25 Mar 2020 09:31:04 +1300 Subject: [PATCH 5/8] Update conformance metadata to have release version v1.19 --- test/e2e/common/podtemplates.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/e2e/common/podtemplates.go b/test/e2e/common/podtemplates.go index 5bf3939ed3a..59cec100ccc 100644 --- a/test/e2e/common/podtemplates.go +++ b/test/e2e/common/podtemplates.go @@ -32,7 +32,7 @@ import ( var _ = ginkgo.Describe("[sig-architecture] PodTemplates", func() { f := framework.NewDefaultFramework("podtemplate") /* - Release : v1.18 + Release : v1.19 Testname: PodTemplate lifecycle Description: Attempt to create a PodTemplate. Patch the created PodTemplate. Fetching the PodTemplate MUST reflect changes. By fetching all the PodTemplates via a Label selector it MUST find the PodTemplate by it's static label and updated value. The PodTemplate must be deleted. From 02f983d8c8af525a048f359c361aa2cdde280699 Mon Sep 17 00:00:00 2001 From: Caleb Woodbine Date: Fri, 27 Mar 2020 08:59:33 +1300 Subject: [PATCH 6/8] Update metadata --- test/conformance/testdata/conformance.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/conformance/testdata/conformance.yaml b/test/conformance/testdata/conformance.yaml index 36f83768091..fa8a3127662 100755 --- a/test/conformance/testdata/conformance.yaml +++ b/test/conformance/testdata/conformance.yaml @@ -1241,7 +1241,7 @@ the PodTemplate MUST reflect changes. By fetching all the PodTemplates via a Label selector it MUST find the PodTemplate by it's static label and updated value. The PodTemplate must be deleted. - release: v1.18 + release: v1.19 file: test/e2e/common/podtemplates.go - testname: Service account tokens auto mount optionally codename: '[sig-auth] ServiceAccounts should allow opting out of API token automount [Conformance]' From a8592dd9d180f5b2398656f614ddbf967ad2c6e6 Mon Sep 17 00:00:00 2001 From: Caleb Woodbine Date: Wed, 1 Apr 2020 10:45:20 +1300 Subject: [PATCH 7/8] Fix sig in podtemplates.go --- test/e2e/common/podtemplates.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/e2e/common/podtemplates.go b/test/e2e/common/podtemplates.go index 59cec100ccc..9d658932e6a 100644 --- a/test/e2e/common/podtemplates.go +++ b/test/e2e/common/podtemplates.go @@ -29,7 +29,7 @@ import ( "github.com/onsi/ginkgo" ) -var _ = ginkgo.Describe("[sig-architecture] PodTemplates", func() { +var _ = ginkgo.Describe("[sig-node] PodTemplates", func() { f := framework.NewDefaultFramework("podtemplate") /* Release : v1.19 From ce97b499652fd8f0443bcee4371646e09023b4c8 Mon Sep 17 00:00:00 2001 From: Caleb Woodbine Date: Wed, 1 Apr 2020 12:54:09 +1300 Subject: [PATCH 8/8] Update conformance metadata --- test/conformance/testdata/conformance.yaml | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/test/conformance/testdata/conformance.yaml b/test/conformance/testdata/conformance.yaml index fa8a3127662..21678de6a92 100755 --- a/test/conformance/testdata/conformance.yaml +++ b/test/conformance/testdata/conformance.yaml @@ -1234,15 +1234,6 @@ StorageClass or a dynamic provisioner. release: v1.9 file: test/e2e/apps/statefulset.go -- testname: PodTemplate lifecycle - codename: '[sig-architecture] PodTemplates should run the lifecycle of PodTemplates - [Conformance]' - description: Attempt to create a PodTemplate. Patch the created PodTemplate. Fetching - the PodTemplate MUST reflect changes. By fetching all the PodTemplates via a Label - selector it MUST find the PodTemplate by it's static label and updated value. - The PodTemplate must be deleted. - release: v1.19 - file: test/e2e/common/podtemplates.go - testname: Service account tokens auto mount optionally codename: '[sig-auth] ServiceAccounts should allow opting out of API token automount [Conformance]' description: Ensure that Service Account keys are mounted into the Pod only when @@ -1695,6 +1686,14 @@ visible at runtime in the container. release: v1.9 file: test/e2e/common/downward_api.go +- testname: PodTemplate lifecycle + codename: '[sig-node] PodTemplates should run the lifecycle of PodTemplates [Conformance]' + description: Attempt to create a PodTemplate. Patch the created PodTemplate. Fetching + the PodTemplate MUST reflect changes. By fetching all the PodTemplates via a Label + selector it MUST find the PodTemplate by it's static label and updated value. + The PodTemplate must be deleted. + release: v1.19 + file: test/e2e/common/podtemplates.go - testname: LimitRange, resources codename: '[sig-scheduling] LimitRange should create a LimitRange with defaults and ensure pod has those defaults applied. [Conformance]'