From ae259748ef702bc637abcf87219081459e56ac68 Mon Sep 17 00:00:00 2001 From: apeeyush Date: Wed, 11 Nov 2015 19:12:18 +0530 Subject: [PATCH] Fix incorrect OOM score description in kubelet/qos The multiplication factor is 10 and not 100 as clear from some other comments in the same file. Also mentioned at https://lwn.net/Articles/391222/. --- pkg/kubelet/qos/memory_policy.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/kubelet/qos/memory_policy.go b/pkg/kubelet/qos/memory_policy.go index 935727b3dc8..b785ab676f4 100644 --- a/pkg/kubelet/qos/memory_policy.go +++ b/pkg/kubelet/qos/memory_policy.go @@ -44,7 +44,7 @@ func isMemoryGuaranteed(container *api.Container) bool { // GetContainerOOMAdjust returns the amount by which the OOM score of all processes in the // container should be adjusted. The OOM score of a process is the percentage of memory it consumes -// multiplied by 100 (barring exceptional cases) + a configurable quantity which is between -1000 +// multiplied by 10 (barring exceptional cases) + a configurable quantity which is between -1000 // and 1000. Containers with higher OOM scores are killed if the system runs out of memory. // See https://lwn.net/Articles/391222/ for more information. func GetContainerOOMScoreAdjust(container *api.Container, memoryCapacity int64) int {