From d327ac6c76371a10a650eca4afb80653284b7e13 Mon Sep 17 00:00:00 2001 From: Miao Luo Date: Wed, 5 Jul 2017 17:07:39 -0700 Subject: [PATCH] vSphere for cloud-controller-manager Implement NodeAddressesByProviderID and InstanceTypeByProviderID for vsphere cloud provider. --- pkg/cloudprovider/providers/vsphere/vsphere.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pkg/cloudprovider/providers/vsphere/vsphere.go b/pkg/cloudprovider/providers/vsphere/vsphere.go index 1f6e68d560e..fe2ff0acbd8 100644 --- a/pkg/cloudprovider/providers/vsphere/vsphere.go +++ b/pkg/cloudprovider/providers/vsphere/vsphere.go @@ -580,7 +580,8 @@ func (vs *VSphere) NodeAddresses(nodeName k8stypes.NodeName) ([]v1.NodeAddress, // This method will not be called from the node that is requesting this ID. i.e. metadata service // and other local methods cannot be used here func (vs *VSphere) NodeAddressesByProviderID(providerID string) ([]v1.NodeAddress, error) { - return []v1.NodeAddress{}, errors.New("unimplemented") + vmName := path.Base(providerID) + return vs.NodeAddresses(vmNameToNodeName(vmName)) } func (vs *VSphere) AddSSHKeyToAllInstances(user string, keyData []byte) error { @@ -663,7 +664,7 @@ func (vs *VSphere) InstanceID(nodeName k8stypes.NodeName) (string, error) { // This method will not be called from the node that is requesting this ID. i.e. metadata service // and other local methods cannot be used here func (vs *VSphere) InstanceTypeByProviderID(providerID string) (string, error) { - return "", errors.New("unimplemented") + return "", nil } func (vs *VSphere) InstanceType(name k8stypes.NodeName) (string, error) {