From 30ecfbc7ee66cad11bb9dbfebbc2a252df35cc79 Mon Sep 17 00:00:00 2001 From: Justin Santa Barbara Date: Tue, 13 Jun 2017 01:17:58 -0400 Subject: [PATCH] aws: remove redundant tests --- pkg/cloudprovider/providers/aws/aws_test.go | 40 --------------------- 1 file changed, 40 deletions(-) diff --git a/pkg/cloudprovider/providers/aws/aws_test.go b/pkg/cloudprovider/providers/aws/aws_test.go index f75c1a571c3..a50eac1fc81 100644 --- a/pkg/cloudprovider/providers/aws/aws_test.go +++ b/pkg/cloudprovider/providers/aws/aws_test.go @@ -322,12 +322,6 @@ func (self *FakeEC2) DescribeInstances(request *ec2.DescribeInstancesInput) ([]* return matches, nil } -func (self *FakeEC2) DescribeAddresses(request *ec2.DescribeAddressesInput) ([]*ec2.Address, error) { - addresses := []*ec2.Address{} - - return addresses, nil -} - type FakeMetadata struct { aws *FakeAWSServices } @@ -1356,37 +1350,3 @@ func TestGetLoadBalancerAdditionalTags(t *testing.T) { } } } - -func TestInstanceIDFromProviderID(t *testing.T) { - testCases := []struct { - providerID string - instanceID string - fail bool - }{ - { - providerID: "aws://i-0194bbdb81a49b169", - instanceID: "i-0194bbdb81a49b169", - fail: false, - }, - { - providerID: "i-0194bbdb81a49b169", - instanceID: "", - fail: true, - }, - } - - for _, test := range testCases { - instanceID, err := instanceIDFromProviderID(test.providerID) - if (err != nil) != test.fail { - t.Errorf("%s yielded `err != nil` as %t. expected %t", test.providerID, (err != nil), test.fail) - } - - if test.fail { - continue - } - - if instanceID != test.instanceID { - t.Errorf("%s yielded %s. expected %s", test.providerID, instanceID, test.instanceID) - } - } -}