From 31538db14537a532ed0771f6dc978ec5776cb367 Mon Sep 17 00:00:00 2001 From: Wojciech Tyczynski Date: Thu, 7 Jul 2016 14:12:57 +0200 Subject: [PATCH] Avoid growing slices --- plugin/pkg/scheduler/algorithm/priorities/priorities.go | 8 ++++---- .../scheduler/algorithm/priorities/selector_spreading.go | 2 +- .../scheduler/algorithm/priorities/taint_toleration.go | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/plugin/pkg/scheduler/algorithm/priorities/priorities.go b/plugin/pkg/scheduler/algorithm/priorities/priorities.go index bebb299b077..1602e1b1b58 100644 --- a/plugin/pkg/scheduler/algorithm/priorities/priorities.go +++ b/plugin/pkg/scheduler/algorithm/priorities/priorities.go @@ -85,7 +85,7 @@ func LeastRequestedPriority(pod *api.Pod, nodeNameToInfo map[string]*schedulerca return schedulerapi.HostPriorityList{}, err } - list := schedulerapi.HostPriorityList{} + list := make(schedulerapi.HostPriorityList, 0, len(nodes.Items)) for i := range nodes.Items { node := &nodes.Items[i] list = append(list, calculateResourceOccupancy(pod, node, nodeNameToInfo[node.Name])) @@ -122,7 +122,7 @@ func (n *NodeLabelPrioritizer) CalculateNodeLabelPriority(pod *api.Pod, nodeName labeledNodes[node.Name] = (exists && n.presence) || (!exists && !n.presence) } - result := []schedulerapi.HostPriority{} + result := make(schedulerapi.HostPriorityList, 0, len(nodes.Items)) //score int - scale of 0-10 // 0 being the lowest priority and 10 being the highest for nodeName, success := range labeledNodes { @@ -166,7 +166,7 @@ func ImageLocalityPriority(pod *api.Pod, nodeNameToInfo map[string]*schedulercac } } - result := []schedulerapi.HostPriority{} + result := make(schedulerapi.HostPriorityList, 0, len(nodes.Items)) // score int - scale of 0-10 // 0 being the lowest priority and 10 being the highest. for nodeName, sumSize := range sumSizeMap { @@ -221,7 +221,7 @@ func BalancedResourceAllocation(pod *api.Pod, nodeNameToInfo map[string]*schedul return schedulerapi.HostPriorityList{}, err } - list := schedulerapi.HostPriorityList{} + list := make(schedulerapi.HostPriorityList, 0, len(nodes.Items)) for i := range nodes.Items { node := &nodes.Items[i] list = append(list, calculateBalancedResourceAllocation(pod, node, nodeNameToInfo[node.Name])) diff --git a/plugin/pkg/scheduler/algorithm/priorities/selector_spreading.go b/plugin/pkg/scheduler/algorithm/priorities/selector_spreading.go index 25e94954a9d..ae80eaa1348 100644 --- a/plugin/pkg/scheduler/algorithm/priorities/selector_spreading.go +++ b/plugin/pkg/scheduler/algorithm/priorities/selector_spreading.go @@ -207,7 +207,7 @@ func (s *SelectorSpread) CalculateSpreadPriority(pod *api.Pod, nodeNameToInfo ma } } - result := []schedulerapi.HostPriority{} + result := make(schedulerapi.HostPriorityList, 0, len(nodes.Items)) //score int - scale of 0-maxPriority // 0 being the lowest priority and maxPriority being the highest for i := range nodes.Items { diff --git a/plugin/pkg/scheduler/algorithm/priorities/taint_toleration.go b/plugin/pkg/scheduler/algorithm/priorities/taint_toleration.go index 2876fc097da..9513f65dede 100644 --- a/plugin/pkg/scheduler/algorithm/priorities/taint_toleration.go +++ b/plugin/pkg/scheduler/algorithm/priorities/taint_toleration.go @@ -100,7 +100,7 @@ func (s *TaintToleration) ComputeTaintTolerationPriority(pod *api.Pod, nodeNameT // The maximum priority value to give to a node // Priority values range from 0 - maxPriority const maxPriority = 10 - result := []schedulerapi.HostPriority{} + result := make(schedulerapi.HostPriorityList, 0, len(nodes.Items)) for _, node := range nodes.Items { fScore := float64(maxPriority) if maxCount > 0 {