From 31afb24244985e8142963089f525efe101604e43 Mon Sep 17 00:00:00 2001 From: Gaurav Singh Date: Sun, 19 Apr 2020 11:31:55 -0400 Subject: [PATCH] [Scheduler] Map deletion complexity: log(n) => O(1) --- pkg/scheduler/framework/plugins/nodevolumelimits/csi.go | 6 ++---- pkg/scheduler/framework/plugins/nodevolumelimits/non_csi.go | 4 +--- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/pkg/scheduler/framework/plugins/nodevolumelimits/csi.go b/pkg/scheduler/framework/plugins/nodevolumelimits/csi.go index a8c4656e173..8d5f857ff6e 100644 --- a/pkg/scheduler/framework/plugins/nodevolumelimits/csi.go +++ b/pkg/scheduler/framework/plugins/nodevolumelimits/csi.go @@ -110,10 +110,8 @@ func (pl *CSILimits) Filter(ctx context.Context, _ *framework.CycleState, pod *v attachedVolumeCount := map[string]int{} for volumeUniqueName, volumeLimitKey := range attachedVolumes { - if _, ok := newVolumes[volumeUniqueName]; ok { - // Don't count single volume used in multiple pods more than once - delete(newVolumes, volumeUniqueName) - } + // Don't count single volume used in multiple pods more than once + delete(newVolumes, volumeUniqueName) attachedVolumeCount[volumeLimitKey]++ } diff --git a/pkg/scheduler/framework/plugins/nodevolumelimits/non_csi.go b/pkg/scheduler/framework/plugins/nodevolumelimits/non_csi.go index 8e721e7f2c2..46305f99be2 100644 --- a/pkg/scheduler/framework/plugins/nodevolumelimits/non_csi.go +++ b/pkg/scheduler/framework/plugins/nodevolumelimits/non_csi.go @@ -244,9 +244,7 @@ func (pl *nonCSILimits) Filter(ctx context.Context, _ *framework.CycleState, pod // filter out already-mounted volumes for k := range existingVolumes { - if _, ok := newVolumes[k]; ok { - delete(newVolumes, k) - } + delete(newVolumes, k) } numNewVolumes := len(newVolumes)