From a0c2af4fcdf8ad3c9276347bf28f89a3187e67d5 Mon Sep 17 00:00:00 2001 From: Gaurav Singh Date: Sun, 19 Apr 2020 09:22:37 -0400 Subject: [PATCH] [Azure] remove unncessary nil check for range --- .../azure/azure_loadbalancer.go | 36 +++++++++---------- 1 file changed, 17 insertions(+), 19 deletions(-) diff --git a/staging/src/k8s.io/legacy-cloud-providers/azure/azure_loadbalancer.go b/staging/src/k8s.io/legacy-cloud-providers/azure/azure_loadbalancer.go index 597e3e70cee..5b89f210f05 100644 --- a/staging/src/k8s.io/legacy-cloud-providers/azure/azure_loadbalancer.go +++ b/staging/src/k8s.io/legacy-cloud-providers/azure/azure_loadbalancer.go @@ -265,26 +265,24 @@ func (az *Cloud) getServiceLoadBalancer(service *v1.Service, clusterName string, } // check if the service already has a load balancer - if existingLBs != nil { - for i := range existingLBs { - existingLB := existingLBs[i] - if strings.EqualFold(*existingLB.Name, defaultLBName) { - defaultLB = &existingLB - } - if isInternalLoadBalancer(&existingLB) != isInternal { - continue - } - status, err = az.getServiceLoadBalancerStatus(service, &existingLB) - if err != nil { - return nil, nil, false, err - } - if status == nil { - // service is not on this load balancer - continue - } - - return &existingLB, status, true, nil + for i := range existingLBs { + existingLB := existingLBs[i] + if strings.EqualFold(*existingLB.Name, defaultLBName) { + defaultLB = &existingLB } + if isInternalLoadBalancer(&existingLB) != isInternal { + continue + } + status, err = az.getServiceLoadBalancerStatus(service, &existingLB) + if err != nil { + return nil, nil, false, err + } + if status == nil { + // service is not on this load balancer + continue + } + + return &existingLB, status, true, nil } hasMode, _, _ := getServiceLoadBalancerMode(service)