From c53661450995ede021f4d52ae0863769d0790c12 Mon Sep 17 00:00:00 2001 From: Haoran Wang Date: Thu, 13 Jul 2017 18:24:46 +0800 Subject: [PATCH] do not close os.Stdin manually --- pkg/kubectl/resource/visitor.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pkg/kubectl/resource/visitor.go b/pkg/kubectl/resource/visitor.go index 6e2e4b9799d..b01619e613a 100644 --- a/pkg/kubectl/resource/visitor.go +++ b/pkg/kubectl/resource/visitor.go @@ -487,11 +487,12 @@ func (v *FileVisitor) Visit(fn VisitorFunc) error { f = os.Stdin } else { var err error - if f, err = os.Open(v.Path); err != nil { + f, err = os.Open(v.Path) + if err != nil { return err } + defer f.Close() } - defer f.Close() // TODO: Consider adding a flag to force to UTF16, apparently some // Windows tools don't write the BOM