github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-18 08:09:58 +00:00
Code Issues Projects Releases Wiki Activity

Add recommendation for using OnRootMismatch

Browse Source
This commit is contained in:
Hemant Kumar 2025-02-24 12:08:09 -05:00
parent 49dabe56d0
commit 32752fe395
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/volume/util/metrics.go
View File

@ -25,6 +25,7 @@ import (
"google.golang.org/grpc/status" "google.golang.org/grpc/status"
"k8s.io/component-base/metrics" "k8s.io/component-base/metrics"
"k8s.io/component-base/metrics/legacyregistry" "k8s.io/component-base/metrics/legacyregistry"
"k8s.io/klog/v2"
"k8s.io/kubernetes/pkg/volume" "k8s.io/kubernetes/pkg/volume"
"k8s.io/kubernetes/pkg/volume/util/types" "k8s.io/kubernetes/pkg/volume/util/types"
) )
@ -102,6 +103,7 @@ func OperationCompleteHook(plugin, operationName string) func(types.CompleteFunc
if c.Migrated != nil { if c.Migrated != nil {
migrated = *c.Migrated migrated = *c.Migrated
} }
klog.Infof("foobar Operation %s took %f", operationName, timeTaken)
StorageOperationMetric.WithLabelValues(plugin, operationName, status, strconv.FormatBool(migrated)).Observe(timeTaken) StorageOperationMetric.WithLabelValues(plugin, operationName, status, strconv.FormatBool(migrated)).Observe(timeTaken)
} }
return opComplete return opComplete

4
pkg/volume/volume_linux.go
View File

@ -121,6 +121,8 @@ func (vo *VolumeOwnership) changePermissionsRecursively() error {
} }
func (vo *VolumeOwnership) monitorProgress(ctx context.Context) { func (vo *VolumeOwnership) monitorProgress(ctx context.Context) {
msg := fmt.Sprintf("Setting volume ownership for %s is taking longer than expected, consider using OnRootMismatch - https://kubernetes.io/docs/tasks/configure-pod-container/security-context/#configure-volume-permission-and-ownership-change-policy-for-pods", vo.dir)
vo.recorder.Event(vo.pod, v1.EventTypeWarning, events.VolumePermissionChangeInProgress, msg)
ticker := time.NewTicker(progressReportDuration) ticker := time.NewTicker(progressReportDuration)
defer ticker.Stop() defer ticker.Stop()
for { for {
@ -134,7 +136,7 @@ func (vo *VolumeOwnership) monitorProgress(ctx context.Context) {
} }
func (vo *VolumeOwnership) logWarning() { func (vo *VolumeOwnership) logWarning() {
msg := fmt.Sprintf("Setting volume ownership for %s, processed %d files", vo.dir, vo.fileCounter.Load()) msg := fmt.Sprintf("Setting volume ownership for %s, processed %d files.", vo.dir, vo.fileCounter.Load())
klog.Warning(msg) klog.Warning(msg)
vo.recorder.Event(vo.pod, v1.EventTypeWarning, events.VolumePermissionChangeInProgress, msg) vo.recorder.Event(vo.pod, v1.EventTypeWarning, events.VolumePermissionChangeInProgress, msg)
} }