github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-08 11:38:15 +00:00
Code Issues Projects Releases Wiki Activity

Return error instead of crashing apiserver when updating services with duplicate nodeports

Browse Source
This commit is contained in:
xiangpengzhao 2017-11-07 14:32:38 +08:00
parent e6ad515315
commit 330517a3a0
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
pkg/registry/core/service/rest.go
View File

@ -617,9 +617,8 @@ func (rs *REST) updateNodePorts(oldService, newService *api.Service, nodePortOp
servicePort.NodePort = int32(nodePortNumber) servicePort.NodePort = int32(nodePortNumber)
nodePort.NodePort = servicePort.NodePort nodePort.NodePort = servicePort.NodePort
} }
// Detect duplicate node ports; this should have been caught by validation, so we panic
if containsNodePort(newNodePorts, nodePort) { if containsNodePort(newNodePorts, nodePort) {
panic("duplicate node port") return fmt.Errorf("duplicate nodePort: %v", nodePort)
} }
newNodePorts = append(newNodePorts, nodePort) newNodePorts = append(newNodePorts, nodePort)
} }