diff --git a/cmd/kubeadm/app/phases/markcontrolplane/markcontrolplane_test.go b/cmd/kubeadm/app/phases/markcontrolplane/markcontrolplane_test.go index b171072f80a..4cbb1226802 100644 --- a/cmd/kubeadm/app/phases/markcontrolplane/markcontrolplane_test.go +++ b/cmd/kubeadm/app/phases/markcontrolplane/markcontrolplane_test.go @@ -45,26 +45,12 @@ func TestMarkControlPlane(t *testing.T) { expectedPatch string }{ { - name: "control-plane label and taint missing", - existingLabels: []string{""}, - existingTaints: nil, - newTaints: []v1.Taint{kubeadmconstants.OldControlPlaneTaint}, - expectedPatch: `{"metadata":{"labels":{"node-role.kubernetes.io/control-plane":"","node.kubernetes.io/exclude-from-external-load-balancers":""}},"spec":{"taints":[{"effect":"NoSchedule","key":"node-role.kubernetes.io/master"}]}}`, - }, - { - name: "control-plane label and taint missing but taint not wanted", + name: "apply default labels", existingLabels: []string{""}, existingTaints: nil, newTaints: nil, expectedPatch: `{"metadata":{"labels":{"node-role.kubernetes.io/control-plane":"","node.kubernetes.io/exclude-from-external-load-balancers":""}}}`, }, - { - name: "control-plane label missing", - existingLabels: []string{""}, - existingTaints: []v1.Taint{kubeadmconstants.OldControlPlaneTaint}, - newTaints: []v1.Taint{kubeadmconstants.OldControlPlaneTaint}, - expectedPatch: `{"metadata":{"labels":{"node-role.kubernetes.io/control-plane":"","node.kubernetes.io/exclude-from-external-load-balancers":""}}}`, - }, { name: "control-plane taint missing", existingLabels: []string{ @@ -72,8 +58,8 @@ func TestMarkControlPlane(t *testing.T) { kubeadmconstants.LabelExcludeFromExternalLB, }, existingTaints: nil, - newTaints: []v1.Taint{kubeadmconstants.OldControlPlaneTaint}, - expectedPatch: `{"spec":{"taints":[{"effect":"NoSchedule","key":"node-role.kubernetes.io/master"}]}}`, + newTaints: []v1.Taint{kubeadmconstants.ControlPlaneTaint}, + expectedPatch: `{"spec":{"taints":[{"effect":"NoSchedule","key":"node-role.kubernetes.io/control-plane"}]}}`, }, { name: "nothing missing", @@ -81,8 +67,8 @@ func TestMarkControlPlane(t *testing.T) { kubeadmconstants.LabelNodeRoleControlPlane, kubeadmconstants.LabelExcludeFromExternalLB, }, - existingTaints: []v1.Taint{kubeadmconstants.OldControlPlaneTaint}, - newTaints: []v1.Taint{kubeadmconstants.OldControlPlaneTaint}, + existingTaints: []v1.Taint{kubeadmconstants.ControlPlaneTaint}, + newTaints: []v1.Taint{kubeadmconstants.ControlPlaneTaint}, expectedPatch: `{}`, }, { @@ -113,8 +99,8 @@ func TestMarkControlPlane(t *testing.T) { Effect: v1.TaintEffectNoSchedule, }, }, - newTaints: []v1.Taint{kubeadmconstants.OldControlPlaneTaint}, - expectedPatch: `{"spec":{"taints":[{"effect":"NoSchedule","key":"node-role.kubernetes.io/master"},{"effect":"NoSchedule","key":"node.cloudprovider.kubernetes.io/uninitialized"}]}}`, + newTaints: []v1.Taint{kubeadmconstants.ControlPlaneTaint}, + expectedPatch: `{"spec":{"taints":[{"effect":"NoSchedule","key":"node-role.kubernetes.io/control-plane"},{"effect":"NoSchedule","key":"node.cloudprovider.kubernetes.io/uninitialized"}]}}`, }, } diff --git a/cmd/kubeadm/app/util/config/cluster_test.go b/cmd/kubeadm/app/util/config/cluster_test.go index 6bc87ff11c0..5cc43a5db17 100644 --- a/cmd/kubeadm/app/util/config/cluster_test.go +++ b/cmd/kubeadm/app/util/config/cluster_test.go @@ -304,7 +304,7 @@ func TestGetNodeRegistration(t *testing.T) { }, }, Spec: v1.NodeSpec{ - Taints: []v1.Taint{kubeadmconstants.OldControlPlaneTaint}, + Taints: []v1.Taint{kubeadmconstants.ControlPlaneTaint}, }, }, }, @@ -559,7 +559,7 @@ func TestGetInitConfigurationFromCluster(t *testing.T) { }, }, Spec: v1.NodeSpec{ - Taints: []v1.Taint{kubeadmconstants.OldControlPlaneTaint}, + Taints: []v1.Taint{kubeadmconstants.ControlPlaneTaint}, }, }, }, @@ -636,7 +636,7 @@ func TestGetInitConfigurationFromCluster(t *testing.T) { }, }, Spec: v1.NodeSpec{ - Taints: []v1.Taint{kubeadmconstants.OldControlPlaneTaint}, + Taints: []v1.Taint{kubeadmconstants.ControlPlaneTaint}, }, }, },