github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-07 11:13:48 +00:00
Code Issues Projects Releases Wiki Activity

Do not error log CRI stats for not cached partitions

Browse Source 
We do not have any cached partitions available on Kubelet start with an
empty container storage in CRI-O. This means that the error log message
is not actually an error and more an information.

This means we now pre-filter those cases and do not `klog.ErrorS` any
more. This helps to avoid log spamming in huge clusters.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
This commit is contained in:
Sascha Grunert 2021-03-22 12:01:59 +01:00
parent af9f7a4d90
commit 337f4e524a
No known key found for this signature in database
GPG Key ID: 09D97D153EF94D93
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
pkg/kubelet/stats/cri_stats_provider.go
View File

@ -26,6 +26,7 @@ import (
"sync" "sync"
"time" "time"
cadvisormemory "github.com/google/cadvisor/cache/memory"
cadvisorfs "github.com/google/cadvisor/fs" cadvisorfs "github.com/google/cadvisor/fs"
cadvisorapiv2 "github.com/google/cadvisor/info/v2" cadvisorapiv2 "github.com/google/cadvisor/info/v2"
"google.golang.org/grpc/codes" "google.golang.org/grpc/codes"
@ -449,7 +450,9 @@ func (p *criStatsProvider) getFsInfo(fsID *runtimeapi.FilesystemIdentifier) *cad
fsInfo, err := p.cadvisor.GetDirFsInfo(mountpoint) fsInfo, err := p.cadvisor.GetDirFsInfo(mountpoint)
if err != nil { if err != nil {
msg := "Failed to get the info of the filesystem with mountpoint" msg := "Failed to get the info of the filesystem with mountpoint"
if err == cadvisorfs.ErrNoSuchDevice { if errors.Is(err, cadvisorfs.ErrNoSuchDevice) ||
errors.Is(err, cadvisorfs.ErrDeviceNotInPartitionsMap) ||
errors.Is(err, cadvisormemory.ErrDataNotFound) {
klog.V(2).InfoS(msg, "mountpoint", mountpoint, "err", err) klog.V(2).InfoS(msg, "mountpoint", mountpoint, "err", err)
} else { } else {
klog.ErrorS(err, msg, "mountpoint", mountpoint) klog.ErrorS(err, msg, "mountpoint", mountpoint)