From 692e7cd3be0bf36d171a7804a7ca4de17e047961 Mon Sep 17 00:00:00 2001 From: HirazawaUi <695097494plus@gmail.com> Date: Sat, 18 Feb 2023 23:37:53 +0800 Subject: [PATCH] delete kubelet unused function --- pkg/kubelet/cm/fake_internal_container_lifecycle.go | 4 ---- pkg/kubelet/cm/internal_container_lifecycle.go | 5 ----- pkg/kubelet/kuberuntime/kuberuntime_container.go | 5 ----- 3 files changed, 14 deletions(-) diff --git a/pkg/kubelet/cm/fake_internal_container_lifecycle.go b/pkg/kubelet/cm/fake_internal_container_lifecycle.go index 78e3baf7efb..d133f28f17c 100644 --- a/pkg/kubelet/cm/fake_internal_container_lifecycle.go +++ b/pkg/kubelet/cm/fake_internal_container_lifecycle.go @@ -35,10 +35,6 @@ func (f *fakeInternalContainerLifecycle) PreStartContainer(pod *v1.Pod, containe return nil } -func (f *fakeInternalContainerLifecycle) PreStopContainer(containerID string) error { - return nil -} - func (f *fakeInternalContainerLifecycle) PostStopContainer(containerID string) error { return nil } diff --git a/pkg/kubelet/cm/internal_container_lifecycle.go b/pkg/kubelet/cm/internal_container_lifecycle.go index 81af2a6dcaa..e3d211ddf2e 100644 --- a/pkg/kubelet/cm/internal_container_lifecycle.go +++ b/pkg/kubelet/cm/internal_container_lifecycle.go @@ -29,7 +29,6 @@ import ( type InternalContainerLifecycle interface { PreCreateContainer(pod *v1.Pod, container *v1.Container, containerConfig *runtimeapi.ContainerConfig) error PreStartContainer(pod *v1.Pod, container *v1.Container, containerID string) error - PreStopContainer(containerID string) error PostStopContainer(containerID string) error } @@ -55,10 +54,6 @@ func (i *internalContainerLifecycleImpl) PreStartContainer(pod *v1.Pod, containe return nil } -func (i *internalContainerLifecycleImpl) PreStopContainer(containerID string) error { - return nil -} - func (i *internalContainerLifecycleImpl) PostStopContainer(containerID string) error { if utilfeature.DefaultFeatureGate.Enabled(kubefeatures.TopologyManager) { err := i.topologyManager.RemoveContainer(containerID) diff --git a/pkg/kubelet/kuberuntime/kuberuntime_container.go b/pkg/kubelet/kuberuntime/kuberuntime_container.go index d7fa0bc15eb..b09bbcf6f90 100644 --- a/pkg/kubelet/kuberuntime/kuberuntime_container.go +++ b/pkg/kubelet/kuberuntime/kuberuntime_container.go @@ -689,11 +689,6 @@ func (m *kubeGenericRuntimeManager) killContainer(ctx context.Context, pod *v1.P } m.recordContainerEvent(pod, containerSpec, containerID.ID, v1.EventTypeNormal, events.KillingContainer, message) - // Run internal pre-stop lifecycle hook - if err := m.internalLifecycle.PreStopContainer(containerID.ID); err != nil { - return err - } - // Run the pre-stop lifecycle hooks if applicable and if there is enough time to run it if containerSpec.Lifecycle != nil && containerSpec.Lifecycle.PreStop != nil && gracePeriod > 0 { gracePeriod = gracePeriod - m.executePreStopHook(ctx, pod, containerID, containerSpec, gracePeriod)