From 61478c04d8ad24d68462b6b8793fb6b359ece294 Mon Sep 17 00:00:00 2001 From: SataQiu Date: Fri, 19 Apr 2019 18:04:54 +0800 Subject: [PATCH] fix golint failures of pkg/apis/batch --- hack/.golint_failures | 1 - pkg/apis/batch/register.go | 4 +++- pkg/apis/batch/types.go | 1 + 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/hack/.golint_failures b/hack/.golint_failures index 8ab29fc3b7a..7ae161b590b 100644 --- a/hack/.golint_failures +++ b/hack/.golint_failures @@ -22,7 +22,6 @@ pkg/apis/autoscaling/v1 pkg/apis/autoscaling/v2beta1 pkg/apis/autoscaling/v2beta2 pkg/apis/autoscaling/validation -pkg/apis/batch pkg/apis/batch/v1 pkg/apis/batch/v1beta1 pkg/apis/batch/v2alpha1 diff --git a/pkg/apis/batch/register.go b/pkg/apis/batch/register.go index 3b4a6d40678..3b1558ab4be 100644 --- a/pkg/apis/batch/register.go +++ b/pkg/apis/batch/register.go @@ -38,8 +38,10 @@ func Resource(resource string) schema.GroupResource { } var ( + // SchemeBuilder points to a list of functions added to Scheme. SchemeBuilder = runtime.NewSchemeBuilder(addKnownTypes) - AddToScheme = SchemeBuilder.AddToScheme + // AddToScheme applies all the stored functions to the scheme. + AddToScheme = SchemeBuilder.AddToScheme ) // Adds the list of known types to the given scheme. diff --git a/pkg/apis/batch/types.go b/pkg/apis/batch/types.go index d62cdaf3bbb..8bbeae8301b 100644 --- a/pkg/apis/batch/types.go +++ b/pkg/apis/batch/types.go @@ -184,6 +184,7 @@ type JobStatus struct { Failed int32 } +// JobConditionType is a valid value for JobCondition.Type type JobConditionType string // These are valid conditions of a job.