Merge pull request #61786 from grayluck/ensureelb-test

Automatic merge from submit-queue (batch tested with PRs 61871, 61890, 61786). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Add unit testcases for ensureExternalLoadBalancer to make sure it doesn't panic when errors raised.

**What this PR does / why we need it**:
Add unit testcases for ensureExternalLoadBalancer to make sure it doesn't panic when errors raised. Increase code coverage from 76.5% to 81.5%.

<!--
**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #

**Special notes for your reviewer**:
-->

**Release note**: 

```release-note
NONE
```

\assign @MrHohn

pkg/cloudprovider/providers/gce/cloud/mock/mock.go

@@ -433,3 +433,38 @@ func GetFirewallsUnauthorizedErrHook(ctx context.Context, key *meta.Key, m *clou
 func GetTargetPoolInternalErrHook(ctx context.Context, key *meta.Key, m *cloud.MockTargetPools) (bool, *ga.TargetPool, error) {
 	return true, nil, &googleapi.Error{Code: http.StatusInternalServerError}
 }
+
+// GetForwardingRulesInternalErrHook mocks getting forwarding rules and returns an internal server error.
+func GetForwardingRulesInternalErrHook(ctx context.Context, key *meta.Key, m *cloud.MockForwardingRules) (bool, *ga.ForwardingRule, error) {
+	return true, nil, &googleapi.Error{Code: http.StatusInternalServerError}
+}
+
+// GetAddressesInternalErrHook mocks getting network address and returns an internal server error.
+func GetAddressesInternalErrHook(ctx context.Context, key *meta.Key, m *cloud.MockAddresses) (bool, *ga.Address, error) {
+	return true, nil, &googleapi.Error{Code: http.StatusInternalServerError}
+}
+
+// GetHTTPHealthChecksInternalErrHook mocks getting http health check and returns an internal server error.
+func GetHTTPHealthChecksInternalErrHook(ctx context.Context, key *meta.Key, m *cloud.MockHttpHealthChecks) (bool, *ga.HttpHealthCheck, error) {
+	return true, nil, &googleapi.Error{Code: http.StatusInternalServerError}
+}
+
+// InsertTargetPoolsInternalErrHook mocks getting target pool and returns an internal server error.
+func InsertTargetPoolsInternalErrHook(ctx context.Context, key *meta.Key, obj *ga.TargetPool, m *cloud.MockTargetPools) (bool, error) {
+	return true, &googleapi.Error{Code: http.StatusInternalServerError}
+}
+
+// InsertForwardingRulesInternalErrHook mocks getting forwarding rule and returns an internal server error.
+func InsertForwardingRulesInternalErrHook(ctx context.Context, key *meta.Key, obj *ga.ForwardingRule, m *cloud.MockForwardingRules) (bool, error) {
+	return true, &googleapi.Error{Code: http.StatusInternalServerError}
+}
+
+// DeleteAddressesNotFoundErrHook mocks deleting network address and returns a not found error.
+func DeleteAddressesNotFoundErrHook(ctx context.Context, key *meta.Key, m *cloud.MockAddresses) (bool, error) {
+	return true, &googleapi.Error{Code: http.StatusNotFound}
+}
+
+// DeleteAddressesInternalErrHook mocks delete address and returns an internal server error.
+func DeleteAddressesInternalErrHook(ctx context.Context, key *meta.Key, m *cloud.MockAddresses) (bool, error) {
+	return true, &googleapi.Error{Code: http.StatusInternalServerError}
+}

pkg/cloudprovider/providers/gce/gce_loadbalancer_external_test.go

@@ -953,3 +953,114 @@ func TestEnsureExternalLoadBalancerDeletedSucceedsOnXPN(t *testing.T) {
 	msg := fmt.Sprintf("%s %s %s", v1.EventTypeNormal, eventReasonManualChange, eventMsgFirewallChange)
 	checkEvent(t, recorder, msg, true)
 }
+
+type EnsureELBParams struct {
+	clusterName     string
+	clusterID       string
+	apiService      *v1.Service
+	existingFwdRule *compute.ForwardingRule
+	nodes           []*v1.Node
+}
+
+// newEnsureELBParams is the constructor of EnsureELBParams.
+func newEnsureELBParams(nodes []*v1.Node) *EnsureELBParams {
+	vals := DefaultTestClusterValues()
+	return &EnsureELBParams{
+		vals.ClusterName,
+		vals.ClusterID,
+		fakeApiService.DeepCopy(),
+		nil,
+		nodes,
+	}
+}
+
+// TestEnsureExternalLoadBalancerErrors tests the function
+// ensureExternalLoadBalancer, making sure the system won't panic when
+// exceptions raised by gce.
+func TestEnsureExternalLoadBalancerErrors(t *testing.T) {
+	vals := DefaultTestClusterValues()
+	var params *EnsureELBParams
+
+	for desc, tc := range map[string]struct {
+		adjustParams func(*EnsureELBParams)
+		injectMock   func(*cloud.MockGCE)
+	}{
+		"No hosts provided": {
+			adjustParams: func(params *EnsureELBParams) {
+				params.nodes = []*v1.Node{}
+			},
+		},
+		"Invalid node provided": {
+			adjustParams: func(params *EnsureELBParams) {
+				params.nodes = []*v1.Node{{}}
+			},
+		},
+		"Get forwarding rules failed": {
+			injectMock: func(c *cloud.MockGCE) {
+				c.MockForwardingRules.GetHook = mock.GetForwardingRulesInternalErrHook
+			},
+		},
+		"Get addresses failed": {
+			injectMock: func(c *cloud.MockGCE) {
+				c.MockAddresses.GetHook = mock.GetAddressesInternalErrHook
+			},
+		},
+		"Bad load balancer source range provided": {
+			adjustParams: func(params *EnsureELBParams) {
+				params.apiService.Spec.LoadBalancerSourceRanges = []string{"BadSourceRange"}
+			},
+		},
+		"Get firewall failed": {
+			injectMock: func(c *cloud.MockGCE) {
+				c.MockFirewalls.GetHook = mock.GetFirewallsUnauthorizedErrHook
+			},
+		},
+		"Create firewall failed": {
+			injectMock: func(c *cloud.MockGCE) {
+				c.MockFirewalls.InsertHook = mock.InsertFirewallsUnauthorizedErrHook
+			},
+		},
+		"Get target pool failed": {
+			injectMock: func(c *cloud.MockGCE) {
+				c.MockTargetPools.GetHook = mock.GetTargetPoolInternalErrHook
+			},
+		},
+		"Get HTTP health checks failed": {
+			injectMock: func(c *cloud.MockGCE) {
+				c.MockHttpHealthChecks.GetHook = mock.GetHTTPHealthChecksInternalErrHook
+			},
+		},
+		"Create target pools failed": {
+			injectMock: func(c *cloud.MockGCE) {
+				c.MockTargetPools.InsertHook = mock.InsertTargetPoolsInternalErrHook
+			},
+		},
+		"Create forwarding rules failed": {
+			injectMock: func(c *cloud.MockGCE) {
+				c.MockForwardingRules.InsertHook = mock.InsertForwardingRulesInternalErrHook
+			},
+		},
+	} {
+		t.Run(desc, func(t *testing.T) {
+			gce, err := fakeGCECloud(DefaultTestClusterValues())
+			nodes, err := createAndInsertNodes(gce, []string{"test-node-1"}, vals.ZoneName)
+			require.NoError(t, err)
+			params = newEnsureELBParams(nodes)
+			if tc.adjustParams != nil {
+				tc.adjustParams(params)
+			}
+			if tc.injectMock != nil {
+				tc.injectMock(gce.c.(*cloud.MockGCE))
+			}
+			status, err := gce.ensureExternalLoadBalancer(
+				params.clusterName,
+				params.clusterID,
+				params.apiService,
+				params.existingFwdRule,
+				params.nodes,
+			)
+			assert.Error(t, err, "Should return an error when "+desc)
+			assert.Nil(t, status, "Should not return a status when "+desc)
+		})
+	}
+}