From f5c6eba92d0b333a44402188d687fb68441d895c Mon Sep 17 00:00:00 2001 From: Mayank Gaikwad <8110509+mgdevstack@users.noreply.github.com> Date: Fri, 30 Aug 2019 17:37:03 +0530 Subject: [PATCH] Add LinuxOnly tag to e2e testing session affinity --- test/e2e/network/networking.go | 6 ++++-- test/e2e/network/service.go | 24 ++++++++++++++++-------- 2 files changed, 20 insertions(+), 10 deletions(-) diff --git a/test/e2e/network/networking.go b/test/e2e/network/networking.go index 1ce032cacbc..146732439dc 100644 --- a/test/e2e/network/networking.go +++ b/test/e2e/network/networking.go @@ -202,7 +202,8 @@ var _ = SIGDescribe("Networking", func() { config.DialFromNode("udp", config.NodeIP, config.NodeUDPPort, config.MaxTries, config.MaxTries, sets.NewString()) }) - ginkgo.It("should function for client IP based session affinity: http", func() { + // [LinuxOnly]: Windows does not support session affinity. + ginkgo.It("should function for client IP based session affinity: http [LinuxOnly]", func() { config := framework.NewNetworkingTestConfig(f) ginkgo.By(fmt.Sprintf("dialing(http) %v --> %v:%v", config.TestContainerPod.Name, config.SessionAffinityService.Spec.ClusterIP, framework.ClusterHTTPPort)) @@ -219,7 +220,8 @@ var _ = SIGDescribe("Networking", func() { } }) - ginkgo.It("should function for client IP based session affinity: udp", func() { + // [LinuxOnly]: Windows does not support session affinity. + ginkgo.It("should function for client IP based session affinity: udp [LinuxOnly]", func() { config := framework.NewNetworkingTestConfig(f) ginkgo.By(fmt.Sprintf("dialing(udp) %v --> %v:%v", config.TestContainerPod.Name, config.SessionAffinityService.Spec.ClusterIP, framework.ClusterUDPPort)) diff --git a/test/e2e/network/service.go b/test/e2e/network/service.go index 55b08f5da0b..b2a02bbba13 100644 --- a/test/e2e/network/service.go +++ b/test/e2e/network/service.go @@ -1804,32 +1804,37 @@ var _ = SIGDescribe("Services", func() { } }) - ginkgo.It("should have session affinity work for service with type clusterIP", func() { + // [LinuxOnly]: Windows does not support session affinity. + ginkgo.It("should have session affinity work for service with type clusterIP [LinuxOnly]", func() { svc := getServeHostnameService("affinity-clusterip") svc.Spec.Type = v1.ServiceTypeClusterIP execAffinityTestForNonLBService(f, cs, svc) }) - ginkgo.It("should be able to switch session affinity for service with type clusterIP", func() { + // [LinuxOnly]: Windows does not support session affinity. + ginkgo.It("should be able to switch session affinity for service with type clusterIP [LinuxOnly]", func() { svc := getServeHostnameService("affinity-clusterip-transition") svc.Spec.Type = v1.ServiceTypeClusterIP execAffinityTestForNonLBServiceWithTransition(f, cs, svc) }) - ginkgo.It("should have session affinity work for NodePort service", func() { + // [LinuxOnly]: Windows does not support session affinity. + ginkgo.It("should have session affinity work for NodePort service [LinuxOnly]", func() { svc := getServeHostnameService("affinity-nodeport") svc.Spec.Type = v1.ServiceTypeNodePort execAffinityTestForNonLBService(f, cs, svc) }) - ginkgo.It("should be able to switch session affinity for NodePort service", func() { + // [LinuxOnly]: Windows does not support session affinity. + ginkgo.It("should be able to switch session affinity for NodePort service [LinuxOnly]", func() { svc := getServeHostnameService("affinity-nodeport-transition") svc.Spec.Type = v1.ServiceTypeNodePort execAffinityTestForNonLBServiceWithTransition(f, cs, svc) }) // TODO: Get rid of [DisabledForLargeClusters] tag when issue #56138 is fixed. - ginkgo.It("should have session affinity work for LoadBalancer service with ESIPP on [Slow] [DisabledForLargeClusters]", func() { + // [LinuxOnly]: Windows does not support session affinity. + ginkgo.It("should have session affinity work for LoadBalancer service with ESIPP on [Slow] [DisabledForLargeClusters] [LinuxOnly]", func() { // L4 load balancer affinity `ClientIP` is not supported on AWS ELB. framework.SkipIfProviderIs("aws") @@ -1840,7 +1845,8 @@ var _ = SIGDescribe("Services", func() { }) // TODO: Get rid of [DisabledForLargeClusters] tag when issue #56138 is fixed. - ginkgo.It("should be able to switch session affinity for LoadBalancer service with ESIPP on [Slow] [DisabledForLargeClusters]", func() { + // [LinuxOnly]: Windows does not support session affinity. + ginkgo.It("should be able to switch session affinity for LoadBalancer service with ESIPP on [Slow] [DisabledForLargeClusters] [LinuxOnly]", func() { // L4 load balancer affinity `ClientIP` is not supported on AWS ELB. framework.SkipIfProviderIs("aws") @@ -1851,7 +1857,8 @@ var _ = SIGDescribe("Services", func() { }) // TODO: Get rid of [DisabledForLargeClusters] tag when issue #56138 is fixed. - ginkgo.It("should have session affinity work for LoadBalancer service with ESIPP off [Slow] [DisabledForLargeClusters]", func() { + // [LinuxOnly]: Windows does not support session affinity. + ginkgo.It("should have session affinity work for LoadBalancer service with ESIPP off [Slow] [DisabledForLargeClusters] [LinuxOnly]", func() { // L4 load balancer affinity `ClientIP` is not supported on AWS ELB. framework.SkipIfProviderIs("aws") @@ -1862,7 +1869,8 @@ var _ = SIGDescribe("Services", func() { }) // TODO: Get rid of [DisabledForLargeClusters] tag when issue #56138 is fixed. - ginkgo.It("should be able to switch session affinity for LoadBalancer service with ESIPP off [Slow] [DisabledForLargeClusters]", func() { + // [LinuxOnly]: Windows does not support session affinity. + ginkgo.It("should be able to switch session affinity for LoadBalancer service with ESIPP off [Slow] [DisabledForLargeClusters] [LinuxOnly]", func() { // L4 load balancer affinity `ClientIP` is not supported on AWS ELB. framework.SkipIfProviderIs("aws")