From 358474b71d82c96fbd5a64f911010995d3e79487 Mon Sep 17 00:00:00 2001 From: vinay kulkarni Date: Fri, 17 Mar 2023 18:00:04 +0000 Subject: [PATCH] Explicitly return from checkpoint update failures. SyncPod will retry --- pkg/kubelet/kubelet.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pkg/kubelet/kubelet.go b/pkg/kubelet/kubelet.go index 6cfba58e91d..5aa9b543df0 100644 --- a/pkg/kubelet/kubelet.go +++ b/pkg/kubelet/kubelet.go @@ -2700,6 +2700,7 @@ func (kl *Kubelet) handlePodResourcesResize(pod *v1.Pod) { if err := kl.statusManager.SetPodAllocation(updatedPod); err != nil { //TODO(vinaykul,InPlacePodVerticalScaling): Can we recover from this in some way? Investigate klog.ErrorS(err, "SetPodAllocation failed", "pod", klog.KObj(pod)) + return } pod = updatedPod } @@ -2708,6 +2709,7 @@ func (kl *Kubelet) handlePodResourcesResize(pod *v1.Pod) { if err := kl.statusManager.SetPodResizeStatus(pod.UID, resizeStatus); err != nil { //TODO(vinaykul,InPlacePodVerticalScaling): Can we recover from this in some way? Investigate klog.ErrorS(err, "SetPodResizeStatus failed", "pod", klog.KObj(pod)) + return } pod.Status.Resize = resizeStatus }