github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-02 16:29:21 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #103863 from tanjing2020/time

Browse Source 
Replace `time.Now().Sub(x)` with `time.Since(x)`
This commit is contained in:
Kubernetes Prow Robot 2021-12-07 18:25:40 -08:00 committed by GitHub
commit 35aa669145
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
staging/src/k8s.io/apimachinery/pkg/util/wait/wait_test.go
View File

@ -754,7 +754,7 @@ func TestJitterBackoffManagerWithRealClock(t *testing.T) {
for i := 0; i < 5; i++ { for i := 0; i < 5; i++ {
start := time.Now() start := time.Now()
<-backoffMgr.Backoff().C() <-backoffMgr.Backoff().C()
passed := time.Now().Sub(start) passed := time.Since(start)
if passed < 1*time.Millisecond { if passed < 1*time.Millisecond {
t.Errorf("backoff should be at least 1ms, but got %s", passed.String()) t.Errorf("backoff should be at least 1ms, but got %s", passed.String())
} }
@ -769,7 +769,7 @@ func TestExponentialBackoffManagerWithRealClock(t *testing.T) {
for i := range durationFactors { for i := range durationFactors {
start := time.Now() start := time.Now()
<-backoffMgr.Backoff().C() <-backoffMgr.Backoff().C()
passed := time.Now().Sub(start) passed := time.Since(start)
if passed < durationFactors[i]*time.Millisecond { if passed < durationFactors[i]*time.Millisecond {
t.Errorf("backoff should be at least %d ms, but got %s", durationFactors[i], passed.String()) t.Errorf("backoff should be at least %d ms, but got %s", durationFactors[i], passed.String())
} }

2
staging/src/k8s.io/apiserver/plugin/pkg/authenticator/token/webhook/webhook.go
View File

@ -137,7 +137,7 @@ func (w *WebhookTokenAuthenticator) AuthenticateToken(ctx context.Context, token
start := time.Now() start := time.Now()
result, statusCode, tokenReviewErr = w.tokenReview.Create(ctx, r, metav1.CreateOptions{}) result, statusCode, tokenReviewErr = w.tokenReview.Create(ctx, r, metav1.CreateOptions{})
latency := time.Now().Sub(start) latency := time.Since(start)
if statusCode != 0 { if statusCode != 0 {
w.metrics.RecordRequestTotal(ctx, strconv.Itoa(statusCode)) w.metrics.RecordRequestTotal(ctx, strconv.Itoa(statusCode))

2
staging/src/k8s.io/apiserver/plugin/pkg/authorizer/webhook/webhook.go
View File

@ -206,7 +206,7 @@ func (w *WebhookAuthorizer) Authorize(ctx context.Context, attr authorizer.Attri
start := time.Now() start := time.Now()
result, statusCode, sarErr = w.subjectAccessReview.Create(ctx, r, metav1.CreateOptions{}) result, statusCode, sarErr = w.subjectAccessReview.Create(ctx, r, metav1.CreateOptions{})
latency := time.Now().Sub(start) latency := time.Since(start)
if statusCode != 0 { if statusCode != 0 {
w.metrics.RecordRequestTotal(ctx, strconv.Itoa(statusCode)) w.metrics.RecordRequestTotal(ctx, strconv.Itoa(statusCode))