github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-09-28 21:55:48 +00:00
Code Issues Projects Releases Wiki Activity

Mark old kubectl/resource.go methods as deprecated

Browse Source 
Every command should use resource.Builder instead to have consistent
behavior.
This commit is contained in:
Clayton Coleman
2015-02-21 18:22:07 -05:00
parent 86a0193f51
commit 35cc1b0c15
6 changed files with 9 additions and 142 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/kubectl/cmd/rollingupdate.go
View File

@@ -68,6 +68,7 @@ func (f *Factory) NewCmdRollingUpdate(out io.Writer) *cobra.Command {
cmdApiVersion := clientConfig.Version
mapper, typer := f.Object(cmd)
// TODO: use resource.Builder instead
mapping, namespace, newName, data := util.ResourceFromFile(filename, typer, mapper, schema, cmdApiVersion)
if mapping.Kind != "ReplicationController" {
usageError(cmd, "%s does not specify a valid ReplicationController", filename)
@@ -79,6 +80,7 @@ func (f *Factory) NewCmdRollingUpdate(out io.Writer) *cobra.Command {
cmdNamespace, err := f.DefaultNamespace(cmd)
checkErr(err)
// TODO: use resource.Builder instead
err = util.CompareNamespace(cmdNamespace, namespace)
checkErr(err)