github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-17 07:39:22 +00:00
Code Issues Projects Releases Wiki Activity

Fix flake in CEL cost stability tests

Browse Source 
A new test was added that uses exists(), which short circuits
when a condition is met.  The test input is a map with random
ordering, so the test can fail when the element that causes
the iteration to short circuit is traversed first.
This commit is contained in:
Joe Betz 2024-11-06 22:09:41 -05:00
parent 4c487b00af
commit 3603555831
1 changed files with 12 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/schema/cel/celcoststability_test.go
View File

@ -372,19 +372,24 @@ func TestCelCostStability(t *testing.T) {
"!('c' in self.val)": 4, "!('c' in self.val)": 4,
"'d' in self.val": 3, "'d' in self.val": 3,
// field selection also possible if map key is a valid CEL identifier // field selection also possible if map key is a valid CEL identifier
"!has(self.val.a)": 3, "!has(self.val.a)": 3,
"has(self.val.b)": 2, "has(self.val.b)": 2,
"!has(self.val.c)": 3, "!has(self.val.c)": 3,
"has(self.val.d)": 2, "has(self.val.d)": 2,
"self.val.all(k, self.val[k] > 0)": 17, "self.val.all(k, self.val[k] > 0)": 17,
// It is important that the condition does not match in this exists test
// since the map iteration order is non-deterministic, and exists short circuits when it matches.
"!self.val.exists(k, self.val[k] == 3)": 20,
"self.val.exists_one(k, self.val[k] == 2)": 14, "self.val.exists_one(k, self.val[k] == 2)": 14,
"!self.val.exists_one(k, self.val[k] > 0)": 17, "!self.val.exists_one(k, self.val[k] > 0)": 17,
"size(self.val) == 2": 4, "size(self.val) == 2": 4,
"size(self.val.filter(k, self.val[k] > 1)) == 1": 26, "size(self.val.filter(k, self.val[k] > 1)) == 1": 26,
// two variable comprehensions // two variable comprehensions
"self.val.all(k, v, v > 0)": 13, "self.val.all(k, v, v > 0)": 13,
"self.val.exists(k, v, v == 2)": 15, // It is important that the condition does not match in this exists test
// since the map iteration order is non-deterministic, and exists short circuits when it matches.
"!self.val.exists(k, v, v == 3)": 16,
"self.val.existsOne(k, v, v == 2)": 10, "self.val.existsOne(k, v, v == 2)": 10,
"self.val.transformMap(k, v, v > 1, v + 1).size() == 1": 14, "self.val.transformMap(k, v, v > 1, v + 1).size() == 1": 14,
"self.val.transformMap(k, v, v + 1).size() == 2": 15, "self.val.transformMap(k, v, v + 1).size() == 2": 15,